fix: consume vss-client 0.5.23 by ovitrif · Pull Request #673 · synonymdev/bitkit-ios

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif · 2026-08-18T10:15:32Z

This PR bumps vss-rust-client-ffi from 0.5.21 to 0.5.23.

Description

0.5.23 includes synonymdev/vss-rust-client-ffi#20. Unauthenticated client setup now returns AuthError instead of encrypting with a public all-zero key.

Companion Android PR: synonymdev/bitkit-android#1164

Linked Issues/Tasks

Screenshot / Video

N/A

QA Notes

Manual Tests

1.regression: Fresh wallet → backup/Lightning start with current Env LNURL-auth URL: setup still succeeds.

Automated Checks

Local Debug simulator build passed against 0.5.23.

greptile-apps · 2026-08-18T10:17:36Z

Greptile Summary

This PR upgrades vss-rust-client-ffi to 0.5.23 and makes VSS initialization fail closed when LNURL-auth configuration is blank.

Removes unauthenticated backup and Lightning-node VSS fallback paths.
Normalizes whitespace in the LNURL-auth URL and adds a dedicated authentication-required error.
Updates the Swift package lockfile and adds a security changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with authenticated VSS initialization consistently replacing the removed unauthenticated fallback.

The changed setup paths reject blank authentication configuration, retain correct failure cleanup, and use the authenticated VSS APIs pinned by the coordinated dependency update; no reachable blocking failure remains.

Important Files Changed

Filename	Overview
Bitkit/Services/LightningService.swift	Removes fixed-header VSS fallback and requires a nonblank LNURL-auth URL before building the Lightning node.
Bitkit/Services/VssBackupClient.swift	Routes app and debug VSS setup exclusively through authenticated client initialization.
Bitkit/Utilities/Errors.swift	Adds the dedicated vssAuthRequired service error and its AppError mapping.
Bitkit.xcodeproj/project.pbxproj	Updates the exact vss-rust-client-ffi package requirement to 0.5.23.
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Pins vss-rust-client-ffi 0.5.23 at the corresponding resolved revision.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Backup or Lightning setup] --> B[Read and trim LNURL-auth URL]
B --> C{URL present?}
C -- No --> D[Throw vssAuthRequired]
C -- Yes --> E[Initialize authenticated VSS client]
E --> F[Proceed with backup or Lightning node]

_{Reviews (1): Last reviewed commit: "fix: consume vss-client 0.5.23" | Re-trigger Greptile}

Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif requested a review from ben-kaufman August 18, 2026 10:15

ovitrif mentioned this pull request Aug 18, 2026
fix: fail closed without vss auth #665
Merged
2 tasks

ovitrif mentioned this pull request Aug 18, 2026
fix: consume vss-client 0.5.23 synonymdev/bitkit-android#1164
Merged
1 task

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from 78f71e8 to 734ffb2Compare August 18, 2026 11:12

ovitrif changed the base branch from master to fix/fail-closed-unauthenticated-vssAugust 18, 2026 11:12

ovitrif self-assigned this Aug 18, 2026

ovitrif added this to the 2.5.0 milestone Aug 18, 2026

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from 734ffb2 to 8a59735Compare August 18, 2026 13:03

ben-kaufman approved these changes Aug 18, 2026
View reviewed changes

Base automatically changed from fix/fail-closed-unauthenticated-vss to masterAugust 18, 2026 18:07

fix: consume vss-client 0.5.23
c56caba
Bump vss-rust-client-ffi to 0.5.23 so unauthenticated VSS encryption is rejected in the library. Related: synonymdev/audit#55, synonymdev/vss-rust-client-ffi#20

ovitrif force-pushed the fix/consume-vss-0.5.23 branch from 8a59735 to c56cabaCompare August 18, 2026 18:07

ovitrif merged commit 625b54e into masterAug 18, 2026
11 checks passed

ovitrif deleted the fix/consume-vss-0.5.23 branch August 18, 2026 20:43

piotr-iohk mentioned this pull request Aug 21, 2026
chore: bump version 2.4.1 #678
Closed

piotr-iohk mentioned this pull request Aug 31, 2026
chore: sync 2.4.1 onto master #695
Merged