feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat: trezor hardware support - #792

Merged
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support
May 18, 2026
Merged

feat: trezor hardware support#792
ovitrif merged 79 commits into
masterfrom
feat/trezor-hardware-support

Conversation

@coreyphillips

@coreyphillipscoreyphillips commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Description

The Trezor dev dashboard gives native developers a place to test and troubleshoot Trezor hardware flows before user-facing Trezor features ship.

This PR:

  1. Adds USB and Bluetooth Trezor transport support.
  2. Adds the dev-only Trezor dashboard at Settings -> Advanced -> Dev Settings -> Trezor.
  3. Adds optional official Trezor Bridge transport behind TREZOR_BRIDGE=true, so the dashboard can be tested through the official Trezor User Env emulator without a physical device.

Preview

QA Notes

Latest bitkit-core bindings with Trezor hardware support: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.58

Official emulator setup:

  1. Clone the official Trezor User Env: git clone https://github.com/trezor/trezor-user-env ~/repos/github/trezor-user-env.
  2. Start it from that folder with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro from commit 280c4e7.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks passed.

Manual dashboard tap-through checklist:

  • Scan shows Trezor Bridge Emulator / Bridge device.
  • Connect succeeds and shows Trezor features.
  • Get address succeeds.
  • Get public key succeeds.
  • Sign and verify message succeed.
  • Send/compose path handles the expected no-funds result: xpub lookup returns NATIVE_SEGWIT, 0 sats, 0 UTXOs, and no send form is shown for the unfunded emulator account.
  • Disconnect, reconnect, and forget-device flows clean up state.

- Implement trezor hardware support via USB and Bluetooth
github-advanced-security[bot]

This comment was marked as outdated.

@coreyphillipscoreyphillips self-assigned this Feb 18, 2026
@coreyphillipscoreyphillips added the enhancement New feature or request label Feb 18, 2026
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Fixed
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
@coreyphillips
coreyphillips marked this pull request as draft March 3, 2026 18:34
Comment threadapp/src/main/java/to/bitkit/services/TrezorService.kt Fixed
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorScreen.kt Fixed
coreyphillipsand others added 3 commits March 5, 2026 12:51
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Bumps bitkit-core version to 0.1.44
- Adds SendTransactionSection.kt
@coreyphillips
coreyphillips marked this pull request as ready for review March 7, 2026 18:48
@jvsena42jvsena42 added this to the 2.2.0 milestone Mar 9, 2026
@jvsena42
jvsena42 self-requested a review March 9, 2026 12:59
# Conflicts:
#	app/src/main/java/to/bitkit/ui/ContentView.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsScreen.kt
#	app/src/main/java/to/bitkit/ui/settings/AdvancedSettingsViewModel.kt
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorDebugLog.kt Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt
Comment threadapp/src/main/res/values/strings.xml Outdated
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/SendTransactionSection.kt Outdated
jvsena42

This comment was marked as resolved.

Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/services/TrezorTransport.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif modified the milestones: 2.2.0, 2.3.0Apr 7, 2026
@ovitrif

This comment was marked as outdated.

@coreyphillips

This comment was marked as outdated.

@ovitrif

This comment was marked as outdated.

@ovitrifovitrif self-assigned this May 11, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from a3fbcf0 to e951e8aCompareMay 11, 2026 18:54
@ovitrifovitrif mentioned this pull request May 11, 2026
8 tasks
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrif

ovitrif commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Follow-up for review #4033332481: the remaining actionable checklist is handled in stacked PR #939.

No unresolved inline review threads remain on this PR or #939 for this checklist.

@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 17, 2026

@ovitrifovitrif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested multiple times on regtest and added trezor device emulation support in 280c4e7 for automated testing.

@ovitrif
ovitrif merged commit 08e7f90 into masterMay 18, 2026
16 of 19 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support branch May 18, 2026 00:24
@ovitrif

ovitrif commented May 18, 2026

Copy link
Copy Markdown
Collaborator

These CI failures were ack'ed and considered non-blocking before merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@coreyphillips@ovitrif@jvsena42@github-advanced-security@piotr-iohk