chore: improve trezor dashboard - #939

Merged
ovitrif merged 19 commits into
masterfrom
feat/trezor-hardware-support-fixes
May 21, 2026
Merged

chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom
feat/trezor-hardware-support-fixes

Conversation

@ovitrif

@ovitrifovitrif commented May 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:

  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.

This PR should be validated only against #792.

Preview

testing-3x.mp4

QA Notes

Base comparison:

Official emulator setup:

  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY

Physical phone install:

  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug

Android emulator install:

  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug

Validation done:

  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.

Regression checklist against #792:

PR can be approved after code review and light smoke testing, without the need for extensive testing.

The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.

claude[bot]
claudeBot reviewed May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
claude[bot]
claudeBot reviewed May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrifovitrif self-assigned this May 11, 2026
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif mentioned this pull request May 11, 2026
Merged
7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed May 11, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1750d15a1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot reviewed May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
@ovitrifovitrif changed the title fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif changed the title fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support-fixes branch from 082436c to b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support-fixes branch 2 times, most recently from f71883d to c224341CompareMay 17, 2026 23:08
Base automatically changed from feat/trezor-hardware-support to masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed the feat/trezor-hardware-support-fixes branch from c224341 to 1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif modified the milestones: 2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed May 18, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:1ecae3dcbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
@ovitrifovitrif mentioned this pull request May 19, 2026
Merged
@ovitrifovitrif modified the milestones: 2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif merged commit 7116e00 into masterMay 21, 2026
17 of 20 checks passed
@ovitrif
ovitrif deleted the feat/trezor-hardware-support-fixes branch May 21, 2026 13:46
This was referenced May 21, 2026
Merged
Merged
@ovitrifovitrif mentioned this pull request Jun 11, 2026
Open
2 tasks
@jvsena42jvsena42 mentioned this pull request Aug 19, 2026
Draft
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels

None yet

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: improve trezor dashboard - #939
Merged
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
May 21, 2026
Merged
chore: improve trezor dashboard#939
ovitrif merged 19 commits into
masterfrom 
feat/trezor-hardware-support-fixes
Conversation
@ovitrif
@ovitrifovitrif
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
  1. Addresses the remaining actionable review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Splits and tightens Trezor UI state, including immutable UI collections and a composite connected-device state.
  4. Adds focused unit coverage for retry, reconnect, filtering, persistence, send guards, BLE close timeout reporting, and ViewModel flows.
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
Official emulator setup:
  1. Use the official Trezor User Env from https://github.com/trezor/trezor-user-env.
  2. Start it from ~/repos/github/trezor-user-env with ./run.sh --no-regtest.
  3. If the Apple Silicon container cannot load SDL3, install the missing runtime packages once with docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.
  4. Start Bridge and a deterministic T2T1 emulator through the User Env controller:
python3 - <<'PY'import asyncio, json, websocketsasync def send(payload): async with websockets.connect('ws://localhost:9001') as ws: await ws.recv() await ws.send(json.dumps(payload)) print(await ws.recv())async def main(): await send({'type': 'bridge-start', 'version': 'node-bridge', 'id': 1}) await send({'type': 'emulator-start', 'model': 'T2T1', 'version': '2-main', 'wipe': True, 'id': 2}) await send({ 'type': 'emulator-setup', 'mnemonic': 'all all all all all all all all all all all all', 'pin': '', 'passphrase_protection': False, 'label': 'Bitkit Test Trezor', 'needs_backup': False, 'id': 3, }) await send({'type': 'background-check', 'id': 4})asyncio.run(main())PY
Physical phone install:
  • adb reverse tcp:21325 tcp:21325
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebug
Android emulator install:
  • TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebug
Validation done:
  • Official Trezor User Env cloned at ~/repos/github/trezor-user-env and started with ./run.sh --no-regtest.
  • Host Python websockets installed for controller commands.
  • User Env controller ping passed.
  • bridge-start with node-bridge passed.
  • T2T1 2-main emulator starts after installing libsdl3-0 and libsdl3-image0 in the container.
  • emulator-setup passed with the deterministic all all ... seed and label Bitkit Test Trezor.
  • curl -X POST http://localhost:21325/enumerate returns the official Bridge device: path=1, id=127.0.0.1:21324, apiType=usb.
  • adb reverse tcp:21325 tcp:21325 passed on the Pixel 10 Pro test phone.
  • Bridge-enabled dev APK built and installed on the Pixel 10 Pro.
  • ./gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.
Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/repositories/TrezorRepo.kt
Outdated

@ovitrifovitrif
self-assigned this
May 11, 2026
@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 11, 2026
@ovitrifovitrif
mentioned this pull request
May 11, 2026
 Merged

7 tasks
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 11, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
claude[bot]
claudeBot
reviewed
May 11, 2026
View reviewed changes
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
changed the title
fix: address trezor review commentsfix: improve trezor dashboardMay 17, 2026
@ovitrifovitrif
changed the title
fix: improve trezor dashboardchore: improve trezor dashboardMay 17, 2026
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
082436c to
b49e879CompareMay 17, 2026 18:21
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support
branch
from
42b92f7 to
280c4e7CompareMay 17, 2026 19:36
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
2 times, most recently
from
f71883d to
c224341CompareMay 17, 2026 23:08

Base automatically changed from
feat/trezor-hardware-support to
masterMay 18, 2026 00:24
@ovitrif
ovitrifforce-pushed
the
feat/trezor-hardware-support-fixes
branch
from
c224341 to
1ecae3dCompareMay 18, 2026 00:29
@ovitrifovitrif
modified the milestones:
2.4.0, 2.3.0May 18, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
May 18, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadapp/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Outdated

@ovitrifovitrif
mentioned this pull request
May 19, 2026
 Merged

@ovitrifovitrif
modified the milestones:
2.3.0, 2.4.0May 20, 2026
@ovitrif
ovitrif
merged commit 7116e00
into
masterMay 21, 2026

17 of 20 checks passed

@ovitrif
ovitrif
deleted the

feat/trezor-hardware-support-fixes

branch
May 21, 2026 13:46

This was referenced May 21, 2026
 Merged

 Merged

@ovitrifovitrif
mentioned this pull request
Jun 11, 2026

Open

2 tasks
@jvsena42jvsena42
mentioned this pull request
Aug 19, 2026
 Draft

6 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments
@claudeclaude[bot]claude[bot] left review comments
@coreyphillipscoreyphillipscoreyphillips approved these changes
@ben-kaufmanben-kaufmanAwaiting requested review from ben-kaufman
@jvsena42jvsena42Awaiting requested review from jvsena42

Assignees

@ovitrifovitrif

Labels


None yet


Projects


None yet


Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif@coreyphillips@piotr-iohk