Uh oh!
There was an error while loading. Please reload this page.
fix(examples): exclude the optional-peer researcher-loop from the examples typecheck - #384
Conversation
…mples typecheck #383 dropped the @tangle-network/agent-knowledge peer dependency (agent-runtime src imports it zero times — the layering is agent-knowledge -> agent-runtime), but left examples/researcher-loop importing @tangle-network/agent-knowledge/profiles. With the peer gone it isn't installed in CI, so typecheck:examples failed on the unresolved import — turning main red and blocking both the merge gate (ci.yml) and the release verify (publish.yml), which run the same pnpm run typecheck. researcher-loop is documented as an optional-peer example (examples/README.md); runLoop is also demonstrated by self-contained examples (driver-loop, ui-audit, supervisor-loop). Exclude this one example from the examples typecheck rather than failing on a peer CI intentionally doesn't install. It still runs for users who install agent-knowledge.
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 5764ab4d
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-25T03:09:19Z
🤖 AI Code Review (ensemble)
SummaryThe PR narrowly scopes an exclusion in tsconfig.examples.json to skip the researcher-loop example, which depends on an optional peer package that isn't installed. The functional change is correct, but the PR introduces inline JSON comments that are incompatible with many tools, and the examples README documentation is now stale. Issues Found2 total — 0 P1 (blocking) · 0 P2 (should fix) · 2 P3 (nice to have)
|
…nt tee #378 (ExecCtx.onSandboxEvent) merged to main but its API-reference regeneration never landed — the docs freshness gate runs after typecheck in ci.yml, and the examples typecheck was failing (the break this PR fixes), so the stale docs were masked. Regenerate docs/api/runtime.md: adds the onSandboxEvent section and refreshes the source line-number links. Generated output only (typedoc).
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 55dc1a8b
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-25T03:28:09Z
🤖 AI Code Review (ensemble)
SummaryThe PR excludes the optional-peer researcher-loop example from the examples tsconfig and updates generated runtime API docs. The tsconfig change is narrowly scoped and well-commented, and the documentation diff is generated markdown with no executable behavior. No concrete blocking issues were identified. No Issues Found✅ APPROVEBoth reviewers and the diff confirm this is a config-only adjustment that preserves the existing typecheck contract for installed dependencies while excluding an example that depends on an optional peer package. The generated API docs add documentation for onSandboxEvent and update line-number references — no executable behavior is introduced. No P1 or P2 issues are present. Synthesized by Sokuza AI from multiple independent reviewers |
Drop the inline // comments from tsconfig.examples.json (clean JSON again, no JSONC-vs-strict-JSON tooling inconsistency) and move the rationale to examples/README.md, which now notes researcher-loop is excluded from typecheck:examples because it needs the optional agent-knowledge peer.
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 4d5f2deb
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-25T03:29:43Z
🤖 AI Code Review (ensemble)
SummaryThe PR excludes the optional-peer researcher-loop example from the examples typecheck and documents the carve-out in the examples README. The tsconfig change is correctly scoped, the README rationale is accurate, and the docs/api/runtime.md line-number updates are harmless. No correctness, security, API contract, or testing concerns. No Issues Found✅ APPROVEBoth independent reviewers approved the change, and the diff confirms it is narrowly scoped and consistent: the tsconfig exclude entry matches the documented exception, the README accurately explains why the optional agent-knowledge peer cannot be typechecked in CI, and no runtime behavior or production code is modified. The docs/api/runtime.md changes are generated API-doc line-number drift and pose no issue. Synthesized by Sokuza AI from multiple independent reviewers |
Uh oh!
There was an error while loading. Please reload this page.
…e output streaming (#385) Ships since v0.77.0: - feat(runtime): ExecCtx.onSandboxEvent per-event tee for live output (#378) - chore(layering): drop the unused agent-knowledge peerDep (#383) - fix(examples): exclude the optional-peer researcher-loop from the examples typecheck (#384) Publishes on the v0.78.0 tag via publish.yml (tag/version lock + OIDC).
Problem
mainCI is red and has been since #383.examples/researcher-loop/imports@tangle-network/agent-knowledge/profiles, but #383 removed the@tangle-network/agent-knowledgepeer dependency (correctly — agent-runtime'ssrcimports it zero times; the layering isagent-knowledge -> agent-runtime). With the peer gone it is no longer installed in CI, sotypecheck:examplesfails on the unresolved import:This is not cosmetic —
pnpm run typecheck(which includestypecheck:examples) runs in both the merge gate (ci.yml) and the release verify (publish.yml), so the break blocks every agent-runtime merge and every publish until it is fixed.Fix
Exclude
examples/researcher-loopfromtsconfig.examples.json.researcher-loopis documented inexamples/README.mdas the optional-peer example ("needs the optional@tangle-network/agent-knowledgepeer"), andrunLoopis also demonstrated by self-contained examples (driver-loop,ui-audit,supervisor-loop,runtime-run). The right move is to stop CI from typechecking an optional-peer example when that peer isn't installed — not to delete a documented example or re-add the peer #383 deliberately dropped. The example still runs for users who installagent-knowledge.No code import references
researcher-loop(only a prose cross-reference indriver-loop), so the exclude is self-contained.Validation
Replicated the CI sequence locally (install → build → typecheck):
pnpm install --frozen-lockfile✓pnpm run build✓pnpm run typecheck→ exit 0 (bothtsc --noEmitandtypecheck:examples)pnpm run lint→ exit 0