🐛 Report a <Testing> boundary only once its body has finished by taras · Pull Request #247 · taras/executable.md

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras · 2026-07-31T05:16:23Z

Rebased onto current main (68f446f). The unrelated #248 TD8 commit that previously rode along here has been removed — it ships separately via #254 and #255.

The regression

#246 migrated <Testing> to a function component and, in doing so, reordered its boundary reporting: the check for a failed body landed afterpersistBoundaryOutcome() and boundary(). A body that stopped — expansion ended by throwing rather than by collecting a diagnostic — therefore still persisted and reported an outcome for tests it never reached.

The spec is explicit that it must not: a stopped body "never counted the tests it did not reach, so it reports no outcome and journals none, and the failure travels on unchanged." The failure check now precedes both.

Coverage

TB1 previously stood a Component.around({ raise }) middleware in for a failure, which masked the real path — a middleware that throws on every raised segment is not how an ordinary component fails. It now registers a real <Boom /> component whose fn throws a module-level sentinel:

run.completion.erroris that sentinel, by identity;
nothing after it rendered (no "AFTER");
no boundary outcome was observed, and none was journalled.

TB2 replays that journal and asserts no boundary outcome hydrates. TB3 (a body that only collected) and TB4 (local component selection) are the controls.

Verified discriminating: with testing-component.ts reverted to main's version, TB1 and TB2 fail while TB3 and TB4 pass either way.

Verification

Deno 2.9.1: fmt, lint (0 errors), check, test (301 passed / 0 failed), check:jsr, pnpm exec tsc --project tsconfig.node.json --noEmit, deno task build + compiled-binary smoke over packages/core/src, git diff --check.

One local note for the record: scripts/tests/build-web-client.test.ts failed in this worktree until I cleared a leftover "sideEffects": false key that an earlier interrupted run had injected into node_modules/@rjsf/validator-ajv8/package.json. That is worktree state, not a code defect — the script correctly refuses to overwrite existing package metadata — and the suite is green once restored.

github-actions · 2026-07-31T05:16:58Z

PR #247: 🐛 Report a boundary only once its body has finished

5 files, +175 / -13

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras force-pushed the fix/testing-boundary-ordering branch from 95c42af to d5f5324Compare July 31, 2026 15:25

🐛 Report a <Testing> boundary only once its body has finished
4e153b0
A body that stopped never counted the tests it did not reach, so it has no outcome to report and journals none — restoring the ordering the handler had before the migration.

taras force-pushed the fix/testing-boundary-ordering branch from d5f5324 to 4e153b0Compare July 31, 2026 17:48

taras merged commit 3d93698 into mainJul 31, 2026
9 checks passed

taras deleted the fix/testing-boundary-ordering branch July 31, 2026 17:55