✨ Register <TestAgent> and <TestAgent.Scenario> as function components - #270
Merged
Conversation
The last package claiming ordinary component names through Component.expand. Both register non-reserved, so a repository component replaces either — the dotted name addresses a subdirectory, so that override is components/TestAgent/Scenario.md. Every prop was already a string literal, so all of them become schema-validated props: neither component declares a capture, and neither relies on the by-reference return default. <TestAgent.Scenario> reads its declaring path from invocation().position, which is all it ever needed from the element. <TestAgent> uses the <Testing> completion shape rather than content(): a body may legally hold a settled diagnostic beside healthy scenarios, and content() would replace the invocation's output with those segments, where tryContent()'s text keeps them inline exactly as the segments it replaced did. A body that genuinely stopped still travels on untouched. The region is deliberately NOT wrapped in scoped(). Content projected by tryContent() anchors to the invocation, not to a child frame, so a context set or middleware installed inside a nested scoped() is invisible to the body — which is what made every scenario report "is valid only inside <TestAgent>" and every prompt "Agent.agent() has no provider". The invocation is already the bound the region needs. The legacy scoped() existed because a claimed element was not an invocation; now it is. Also: TestAgentCtx reads with get() rather than expect(). It is declared `TestAgentSession | undefined` with an undefined default, and the line below it already handles undefined, so expect() could only ever throw where the code meant to branch. The Component.expand install is kept with no arms; retiring the surface is the legacy-removal slice's job, together with <WhenPrompt>, which is claimed inside the worker's own execution.
PR #270: ✨ Register |
TV13 pins the regression the scoped() removal fixes: a scenario in the body sees the session <TestAgent> installed. TV14 is TC1's analog — a settled diagnostic renders inline beside a healthy scenario and the rest of the body still runs, where content() would have replaced the invocation's whole output with it. Both verified red against a restored scoped() wrapper, with the mutation confirmed to have applied. TV14 also pins the empty-string src: the schema accepts "" as a string, so the component's own check still owns that wording and did not move. Parity audit, by grep rather than assertion: no existing test asserted any of the three diagnostics that moved to schema rejections — the agent-prop literal checks on both components and Scenario's missing-src case. That is why the suites passed unchanged, not because nothing moved. The new wording source is the engine's PropValidationError. Spec states what registration makes true: both are non-reserved registered defaults a repository component replaces, the dotted name resolves to components/TestAgent/Scenario.md, and props are schema-validated. The controller now stops with the invocation rather than a nested scope.
TV15 pins that a repository component overrides either registered name, including the dotted one at components/TestAgent/Scenario.md. The fixtures were invisible because the default component dirs resolve against the process cwd, not the temp project — the testing package's harness gets away with it through useStubFs. runDoc now threads componentDirs, relative to the fixture directory. Mutation attestation, each confirmed applied before the run and reverted after: boundary() keys on the nearest eval scope instead of testScope → TV8, TV10, TV11 red. The multi-prompt tests, which is exactly the signature of the regression this key exists to prevent. installPromptFailurePolicy made unconditional → nothing red. A coverage gap, reported rather than papered over. The gap is left open deliberately. The obvious pin — a prompt failing outside a <Test> rendering a diagnostic while the document carries on — does not hold: such a prompt renders nothing at all, so the assertion has no observable to stand on. That behavior is worth understanding before a test is written against it, and guessing at one that passes for the wrong reason would be worse than naming the gap.
| // NOT wrapped in scoped(): content projected by tryContent() anchors to the | ||
| // invocation, not to a child frame, so anything installed inside a scoped() | ||
| // here would be invisible to the body. The invocation is already the bound | ||
| // this region needs — it is dismantled with the component. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // this region needs — it is dismantled with the component. |
| // Non-reserved defaults: a repository component of either name is chosen | ||
| // ahead of these. The dotted name addresses a subdirectory, so the override | ||
| // for the second is components/TestAgent/Scenario.md. |
There was a problem hiding this comment.
Redundant comment — restates what the code does.
Suggested change
| // for the second is components/TestAgent/Scenario.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#202.
packages/test-agentwas the last package claiming ordinary component names throughComponent.expand.The migration
Both register non-reserved, so a repository component replaces either. The dotted name addresses a subdirectory (
probeComponentPathdoesname.replace(/\./g, "/")), so that override iscomponents/TestAgent/Scenario.md.Every prop was already a string literal, so all become schema-validated props: neither component declares a capture, and neither relies on the by-reference return default —
<TestAgent>returns its rendered body text,<TestAgent.Scenario>returns"". This slice consumes the post-#265 surface only in that returningunknownis now the signature.<TestAgent.Scenario>reads its declaring path frominvocation().position, which is all it ever needed from the element.<TestAgent>uses the<Testing>completion shape rather thancontent(): a body may legally hold a settled diagnostic beside healthy scenarios, andcontent()would replace the invocation's output with those segments (CF19 pins that).tryContent()'stextkeeps them inline exactly as the segments it replaced did — TC1 is the behavioural precedent. A body that genuinely stopped still travels on untouched, per #247.The finding: content anchors to the invocation, not to a child frame
The migration failed at first with the body rendering nothing at all. Diagnosis, in order:
content()empty even for trivial children. That repro was invalid — the harness lacked theExpansionFrameprovider — and it produced no core change. Worth recording, because concluding an engine gap from it would have repeated an earlier wrong turn.runDocrepro withscoped()+tryContent()rendered fine, and stayed fine through the whole region — controller, policy,Agent.around. It was under-shaped: its body was plain text needing no context.failure=MissingContextError: testAgent.session, then, after switching toget(), a body reporting "is valid only inside<TestAgent>" and "Agent.agent() has no provider".Content projected by
tryContent()anchors to the invocation, not to ascoped()inside the fn — so a context set or middleware installed in a nested frame is invisible to the body. The legacyscoped()existed because a claimed element was not an invocation; now it is, and the invocation is already the bound the region needs. No engine change: this is the slice using the boundary correctly.Also
TestAgentContextis read withget()rather thanexpect(). It is declaredTestAgentSession | undefinedwith anundefineddefault and the line below already branches onundefined, soexpect()could only ever throw where the code meant to branch.Scope
The
Component.expandinstall is kept with no arms — retiring the surface is the legacy-removal slice's job, together with<WhenPrompt>, which is claimed inside the worker's own execution (worker/run.ts:185) around a scenario document rather than the user's. Flagged so the "count becomes zero" audit accounts for it.Verification
Deno 2.9.1:
fmt,lint(0 errors),check,test(314 passed / 0 failed),check:jsr,pnpm exec tsc --project tsconfig.node.json --noEmit,deno task build+ compiled-binary smoke,git diff --check,node.tsmode checked after the build. All 15 test-agent suites pass unchanged — no test needed updating, so there is no suite-parity claim to audit.