Skip to content

Function ops - #327

Merged
karllessard merged 14 commits into
tensorflow:masterfrom
rnett:rn_function_ops
Jun 26, 2021
Merged

Function ops#327
karllessard merged 14 commits into
tensorflow:masterfrom
rnett:rn_function_ops

Conversation

@rnett

Copy link
Copy Markdown
Contributor

Generates ops that take functions as parameters.

@karllessard

Copy link
Copy Markdown
Collaborator

@rnett any way you can split that in multiple smaller PRs?

@rnett

rnett commented Jun 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Yikes, I'm not sure why it changed all the op classes.

@rnett

rnett commented Jun 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Ok @karllessard, the big change is in #328, I haven't applied it. If you merge that PR I'll do another one with the generation, and then this one will be smaller after rebasing.

@rnett

rnett commented Jun 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Also @JimClarke5 this is what I was talking about wrt the runtime initialization checks, you should be able to use ifOp for that without too much trouble. Although I'm not sure it's a great idea, and I'm working on the init scope PR (and variables soonish after that).

@karllessard

Copy link
Copy Markdown
Collaborator

@rnett can you please rebase this PR now that we are on TF2.5? I guess new ops might also be added?

@rnett

Copy link
Copy Markdown
ContributorAuthor

I'm going to wait until #328 if you think you can merge it quickly, since this one needs to be rebased on top of it anyways.

@rnett

Copy link
Copy Markdown
ContributorAuthor

Ok, it's rebased. The number of files is smaller, but still pretty big since the generation is in there. I can try to make it smaller if you want, but if you need to check for groups it might be required anyways.

@karllessard

Copy link
Copy Markdown
Collaborator

The number of files if fine, since most of the are generated (so I don't need to spend time reviewing them). Some ops needs to be reclassified into the right package though (like ReduceDataset).

rnett added 12 commits June 24, 2021 23:37
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
@google-cla

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karllessard

Copy link
Copy Markdown
Collaborator

@googlebot I consent.

@karllessard
karllessard merged commit 81fb7e7 into tensorflow:masterJun 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rnett@karllessard