Uh oh!
There was an error while loading. Please reload this page.
Function ops - #327
Conversation
karllessard
commented
Jun 1, 2021
@rnett any way you can split that in multiple smaller PRs? |
rnett
commented
Jun 1, 2021
Yikes, I'm not sure why it changed all the op classes. |
rnett
commented
Jun 1, 2021
Ok @karllessard, the big change is in #328, I haven't applied it. If you merge that PR I'll do another one with the generation, and then this one will be smaller after rebasing. |
rnett
commented
Jun 1, 2021
Also @JimClarke5 this is what I was talking about wrt the runtime initialization checks, you should be able to use |
karllessard
commented
Jun 16, 2021
@rnett can you please rebase this PR now that we are on TF2.5? I guess new ops might also be added? |
rnett
commented
Jun 16, 2021
I'm going to wait until #328 if you think you can merge it quickly, since this one needs to be rebased on top of it anyways. |
rnett
commented
Jun 16, 2021
Ok, it's rebased. The number of files is smaller, but still pretty big since the generation is in there. I can try to make it smaller if you want, but if you need to check for groups it might be required anyways. |
karllessard
commented
Jun 16, 2021
The number of files if fine, since most of the are generated (so I don't need to spend time reviewing them). Some ops needs to be reclassified into the right package though (like |
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
karllessard
commented
Jun 26, 2021
@googlebot I consent. |
Generates ops that take functions as parameters.