Uh oh!
There was an error while loading. Please reload this page.
activations, constraints, initializers, losses, regularizers: move Ops param from CTOR to call method - #329
Conversation
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
Pull latest tensorflow master
Merge with latest
Resync with origin/master
Sync with tensorflow/java master
Sync with Metrics Phase 2
Sync with master
Sync with Regularizers
karllessard
commented
Jun 1, 2021
Will merge after #331, if the quick-build passes. |
karllessard
commented
Jun 1, 2021
@JimClarke5 , can you rebase your PR so that we can validate now that the quick-build is passing? |
JimClarke5
commented
Jun 1, 2021
@karllessard I think I have rebased it. Give it a try. |
It failed again, looks like it’s the javadoc trouble that is back :-|
Wait, I think I'm confusing things... I'll try to demystify that later |
karllessard
commented
Jun 2, 2021
I see that you merged master to your branch, I don’t think that’s the issue but rebasing is always better. You can drop your last commit (the merge one) and retry with |
karllessard
commented
Jun 2, 2021
Oh wait, in fact, these javadoc errors are real errors this time :) Can you please fix them and push a new version? |
JimClarke5
commented
Jun 2, 2021
@karllessard@rnett The "check format" is erroring on lines between imports. I ran |
karllessard
commented
Jun 2, 2021
The way to reformat now is to run |
JimClarke5
commented
Jun 2, 2021
@karllessard I did the |
This PR moves the
Opsparameter out of the classCTORs into their respectivecallmethods. Also, an interface was created for each package for the respectivecallmethod. These packages were chosen because they are stateless wrt the Graph (e.g. noVariables).There is no change in functionality of these classes, just the move of the
Opsparameter tocall.This is related to issue: #327