Uh oh!
There was an error while loading. Please reload this page.
Conversation
| withEnv("CEPH_DEMO_SECRET_KEY", awsSecretKey); | ||
| withEnv("CEPH_DEMO_BUCKET", bucketName); | ||
| withExposedPorts(REST_API_PORT, S3_PORT); | ||
| waitingFor( |
There was a problem hiding this comment.
I'd move "non-dynamic" config to the constructor, otherwise the users won't be able to override it
| private NetworkAutoDetectMode networkAutoDetectMode = NetworkAutoDetectMode.IPV4_ONLY; | ||
| public CephContainer() { | ||
| super(IMAGE + ":" + DEFAULT_TAG); |
There was a problem hiding this comment.
| super(IMAGE + ":" + DEFAULT_TAG); | |
| this(IMAGE + ":" + DEFAULT_TAG); |
| ); | ||
| } | ||
| public AwsClientBuilder.EndpointConfiguration getAWSEndpointConfiguration() { |
There was a problem hiding this comment.
IIRC we agreed not to use 3rd party types in our public API (plus, I believe it may not work with AWS SDK v2)
| } | ||
| @Test | ||
| public void testS3Object() throws IOException { |
There was a problem hiding this comment.
perhaps we don't need both tests (or at least should make the container static + @ClassRule to avoid having to start it twice)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
BlackYoup
commented
May 24, 2021
Hello, are you still interested on supporting ceph? I've been writing a lib on my own to support it before finding this PR. I can help finish this if needed. Also as a side note for this PR, it could be great to have a way to define which daemons to start using the Let me know if I can be of any help here. |
I hope everyone that sees this issue in the future is using the ceph community module which is listed on testcontainers.com: |
Replaces #497 - I don't have permission to push to the original branch.