Skip to content

Add ceph support - #497

Closed
tolkonepiu wants to merge 9 commits into
testcontainers:masterfrom
tolkonepiu:ceph
Closed

Add ceph support#497
tolkonepiu wants to merge 9 commits into
testcontainers:masterfrom
tolkonepiu:ceph

Conversation

@tolkonepiu

Copy link
Copy Markdown
Contributor

Add support for Ceph

@bsideupbsideup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I requested some changes, but in general, it looks good :)

Comment threadmodules/ceph/pom.xml Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
@bsideupbsideup removed this from the 1.5.0 milestone Jan 15, 2018
@rnorth

Copy link
Copy Markdown
Member

We're shortly going to be merging #574, which changes our build system to Gradle. This is in part intended to make contributions of modules easier (per #564), but unfortunately means that for a short while your PR is going to show merge conflicts with the master branch.

I just want to let you know we don't want to create new work for you: we'll take care of the merge conflicts shortly. Please don't worry - we're grateful for your PR and want to help integrate it soon. Thank you.

@tolkonepiu

Copy link
Copy Markdown
ContributorAuthor

@rnorth done

@stale

staleBot commented Jan 7, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stalestaleBot added the stale label Jan 7, 2019
@rnorth

Copy link
Copy Markdown
Member

We should keep this open.

Sent with GitHawk

@kiview

Copy link
Copy Markdown
Member

@rnorth Something missing for you? Seems good to merge.

@stalestaleBot removed the stale label Jan 8, 2019
@bsideup

Copy link
Copy Markdown
Member

@kiview we should remove at least the self typing here

Comment threadmodules/ceph/build.gradle Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
Comment threadmodules/ceph/src/main/java/org/testcontainers/containers/CephContainer.java Outdated
@tolkonepiu

Copy link
Copy Markdown
ContributorAuthor

@bsideup ping

@rnorth

Copy link
Copy Markdown
Member

FWIW I've raised this ticket around the current gap in our docs for new module contributors. I'd like to have a bit of a think about the third point specifically before merging this, but otherwise I'm fine with this new module at an overall level: #1503

@stale

staleBot commented Aug 26, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stalestaleBot added the stale label Aug 26, 2019
@rnorth

Copy link
Copy Markdown
Member

Not stale - reopening.

@stalestaleBot removed the stale label Aug 26, 2019
@stale

staleBot commented Nov 24, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stalestaleBot added the stale label Nov 24, 2019
@stalestaleBot removed the stale label Nov 25, 2019
@stale

staleBot commented Feb 27, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stalestaleBot added the stale label Feb 27, 2020
@rnorthrnorth removed the stale label Mar 5, 2020
@rnorthrnorth mentioned this pull request May 8, 2020
@rnorth

Copy link
Copy Markdown
Member

I've made some tweaks but cannot push to the original branch, so have raised #2687. Will close this original PR.

@rnorthrnorth closed this May 8, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tolkonepiu@rnorth@kiview@bsideup