Skip to content

Added ClickHouse support - #173

Merged
tillahoffmann merged 2 commits into
testcontainers:masterfrom
yakimka:clickhouse
Apr 3, 2022
Merged

Added ClickHouse support#173
tillahoffmann merged 2 commits into
testcontainers:masterfrom
yakimka:clickhouse

Conversation

@yakimka

@yakimkayakimka commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Added a testcontainer for the ClickHouse database.

@codecov-commenter

codecov-commenter commented Mar 28, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #173 (2bd1eaf) into master (1f0ca14) will increase coverage by 0.51%.
The diff coverage is 100.00%.

❗ Current head 2bd1eaf differs from pull request most recent head 5f589e8. Consider uploading reports for the commit 5f589e8 to get more accurate results

@@ Coverage Diff @@## master #173 +/- ##
==========================================
+ Coverage 85.08% 85.60% +0.51% 
==========================================
Files 24 25 +1 Lines 637 653 +16 Branches 61 60 -1 ==========================================
+ Hits 542 559 +17 
Misses 75 75 + Partials 20 19 -1
Impacted FilesCoverage Δ
testcontainers/clickhouse.py100.00% <100.00%> (ø)
testcontainers/compose.py100.00% <0.00%> (+1.75%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 066b178...5f589e8. Read the comment docs.

@yakimka

yakimka commented Mar 31, 2022

Copy link
Copy Markdown
ContributorAuthor

@tillahoffmann can you review this, please?

tillahoffmann
tillahoffmann reviewed Apr 1, 2022
View reviewed changes

@tillahoffmanntillahoffmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions, but looks great otherwise!

Comment threadtestcontainers/clickhouse.py Outdated
Comment threadtestcontainers/clickhouse.py Outdated
@tillahoffmann
tillahoffmann merged commit 2aefee2 into testcontainers:masterApr 3, 2022
@yakimka
yakimka deleted the clickhouse branch April 3, 2022 18:50
@tillahoffmanntillahoffmann mentioned this pull request Apr 27, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tillahoffmanntillahoffmanntillahoffmann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yakimka@codecov-commenter@tillahoffmann