Skip to content

Make the GCP PubSub container work - #209

Closed
hy9be wants to merge 4 commits into
testcontainers:masterfrom
hy9be:fix-gcp-pubsub
Closed

Make the GCP PubSub container work#209
hy9be wants to merge 4 commits into
testcontainers:masterfrom
hy9be:fix-gcp-pubsub

Conversation

@hy9be

@hy9behy9be commented Apr 24, 2022

Copy link
Copy Markdown

Accidentally closed the PR under review #183 and cannot reopen it. Recreated this one.

Changes

@hy9behy9be changed the title Fix gcp pubsubMake the GCP pubsub container workApr 24, 2022
@hy9behy9be changed the title Make the GCP pubsub container workMake the GCP PubSub container workApr 24, 2022
@tillahoffmann

tillahoffmann commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Thanks for the updated PR! It looks like it is reverting a number of changes introduced in previous work, e.g the docker version from #203 or clickhouse support from #173. This may be the result of copying code from an outdated branch. That's also the reason for early test failures.

@hy9be

Copy link
Copy Markdown
Author

Yeah, I think you are right. I will take a look.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hy9be@tillahoffmann