Skip to content

Update compose to work with both "docker-compose" as well as "docker compose" - #312

Closed
jhnnsrs wants to merge 4 commits into
testcontainers:mainfrom
jhnnsrs:master
Closed

Update compose to work with both "docker-compose" as well as "docker compose" #312
jhnnsrs wants to merge 4 commits into
testcontainers:mainfrom
jhnnsrs:master

Conversation

@jhnnsrs

Copy link
Copy Markdown

Fixes#306

Sorry for the deletion of the old pull-request.

Fixed using docker compose with the new "docker compose" api as well
as the older "docker-compose" api.

@ash1425ash1425 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pffijtpffijt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole repository has now a different structure (after pr #290) could you apply the changes in compose/testcontainers/compose/init.py?

@bercikr

Copy link
Copy Markdown

what do we need to do to get this approved, can I reopen the pull request. We are hitting an issue related to this...

@tillahoffmann

tillahoffmann commented May 25, 2023

Copy link
Copy Markdown
Contributor

We need a rebase on main to get this merged and adopt the new repository structure.

@tillahoffmann

Copy link
Copy Markdown
Contributor

Closing in favor of #362.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring the docker-compose executable path

5 participants

@jhnnsrs@bercikr@tillahoffmann@ash1425@pffijt