Uh oh!
There was an error while loading. Please reload this page.
Add support for docker compose v2 - #362
Conversation
Seems edit: pushed a commit to drop it, but seems github is having some issues at the moment edit edit: the fix never got picked up by the PR for some reason, so squashed and force-pushed to get it in. should be good to go now |
balint-backmaker
left a comment
There was a problem hiding this comment.
Nice! Glad to see more people looking at this! ❤️
I've got one small request but I'm no codeowner so no "request changes")
Uh oh!
There was an error while loading. Please reload this page.
psschwei
commented
Jun 15, 2023
@tillahoffmann a few of the tests were canceled, but I didn't see any errors in the logs... is there anything else needed for this one? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tillahoffmann
commented
Jun 21, 2023
They were cancelled because the tests timed out after a few hours. There are likely some issues with spinning up the containers. |
psschwei
commented
Jul 6, 2023
looks like I may need to add a comment to get the "requires attention" label back 😄 |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
balint-backmaker
commented
Aug 21, 2023
Hey folks! I know things may be going slow right now, but I'd love to put some effort into #358 and would love to do so after this PR has been merged (likely to overhaul the compose package, but this contains some good ideas I want to keep) |
psschwei
commented
Sep 25, 2023
@tillahoffmann gentle ping |
psschwei
commented
Nov 27, 2023
The compose module was removed in #394 , so doesn't seem there's any need for this PR anymore... |
kiview
commented
Nov 28, 2023
As said in #394 (comment), we are interested in bringing back support to Compose v2 without depending on the Python Docker Compose v1 dependency (so only delegating to the binary). Can this PR be adopted towards this approach? |
psschwei
commented
Nov 28, 2023
I understand the rationale for dropping the compose module. No hard feelings there 😄 As for adapting the PR... that's a possibility, though I'm not sure if/when I'd have the cycles... so and rather leaving the PR open indefinitely, I figured I'd go ahead and close it. If someone else wanted to resurrect it, that'd be okay with me too. |
Co-authored-by: Johannes Roos jhnnsrs@gmail.com
Fixes#306
Uses @jhnnsrs 's approach in #312 while refactoring to use the new structure post #290
Also tweaked the tests a bit so they would pass when using
docker compose