Skip to content

ASoC: sdw_utils: Add quirk to ignore sdca RT712/RT721 CODEC_MIC - #5739

Merged
bardliao merged 2 commits into
thesofproject:topic/sof-devfrom
macchian:dev-pch-dmic
May 8, 2026
Merged

ASoC: sdw_utils: Add quirk to ignore sdca RT712/RT721 CODEC_MIC#5739
bardliao merged 2 commits into
thesofproject:topic/sof-devfrom
macchian:dev-pch-dmic

Conversation

@macchian

@macchianmacchian commented Apr 17, 2026

Copy link
Copy Markdown

When the sof driver selects the ACPI machine tables, some SKUs use the host PCH_DMIC;add quirk to ignore the CODEC_MIC if found in disco table.

@macchianmacchian mentioned this pull request Apr 17, 2026
Merged
CopilotAI reviewed Apr 17, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a SoundWire machine-driver quirk mapping so specific SDCA Realtek codecs (RT712/RT721) can skip exposing their CODEC_MIC endpoint on SKUs that instead route microphone capture through the host PCH DMIC when ACPI machine tables are used.

Changes:

  • Mark RT712-SDCA MIC endpoint (aif3) with SOC_SDW_CODEC_MIC quirk and set it as an exclude-quirtk.
  • Mark RT721-SDCA MIC endpoint (aif3) with SOC_SDW_CODEC_MIC quirk and set it as an exclude-quirk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@macchian

macchian commented Apr 23, 2026

Copy link
Copy Markdown
Author

@lgirdwood , could you help review it? Thank you.

ujfalusi
ujfalusi reviewed Apr 23, 2026
View reviewed changes
Comment threadsound/soc/sdw_utils/soc_sdw_utils.c
@macchian
macchian requested a review from ujfalusiApril 23, 2026 07:44
@macchian
macchian requested a review from bardliaoMay 4, 2026 03:20
@bardliao

bardliao commented May 4, 2026

Copy link
Copy Markdown
Collaborator

The Fixes: commit looks weird. Shouldn't it be 9489db9 ("ASoC: sdw_utils: add SmartMic DAI for RT712 VB")? Or split into 2 commits and the other Fixes commit should be 846a8d3 ("ASoC: Intel: soc-acpi-intel-ptl-match: Add rt721 support")

@macchian

macchian commented May 5, 2026

Copy link
Copy Markdown
Author

The Fixes: commit looks weird. Shouldn't it be 9489db9 ("ASoC: sdw_utils: add SmartMic DAI for RT712 VB")? Or split into 2 commits and the other Fixes commit should be 846a8d3 ("ASoC: Intel: soc-acpi-intel-ptl-match: Add rt721 support")

Thanks for point that out. My tag suppose not the earliest patch. I have updated it according to your suggestion as two Fixes tags.

macchianand others added 2 commits May 7, 2026 12:02
@macchianMac Chiang
ASoC: sdw_utils: Add quirk to ignore RT712 CODEC_MIC
d03ea45
Some devices do not use CODEC_MIC but use the host PCH_DMIC
instead. Add a quirk to skip the CODEC_MIC DAI when it is not present
in disco table, ensuring the correct capture device is used.
If CODEC_MIC is present, it continues to be used as default.
Fixes: 9489db9 ("ASoC: sdw_utils: add SmartMic DAI for RT712 VB")
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Mac Chiang
ASoC: sdw_utils: Add quirk to ignore RT721 CODEC_MIC
df8fe62
Add a quirk to skip the CODEC_MIC DAI when it is not present.
This ensures PCH_DMIC is used as the fallback; otherwise,
CODEC_MIC remains the default.
Fixes: 846a8d3 ("ASoC: Intel: soc-acpi-intel-ptl-match: Add rt721 support")
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@bardliao
bardliao merged commit 62f519a into thesofproject:topic/sof-devMay 8, 2026
9 of 16 checks passed
@aachen0aachen0 mentioned this pull request Jul 30, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bardliaobardliaobardliao approved these changes
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@ranj063ranj063Awaiting requested review from ranj063ranj063 is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@shumingfanshumingfanAwaiting requested review from shumingfan
@ujfalusiujfalusiAwaiting requested review from ujfalusiujfalusi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macchian@bardliao@ujfalusi