Merge DTS support for PTL by joechengxperi · Pull Request #10678 · thesofproject/sof

joechengxperi · 2026-04-03T11:31:20Z

No description provided.

This patch adds DTS_CODEC for Intel PTL platform builds. Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

Copilot

Pull request overview

Adds DTS-based pipeline configurations for the PTL SoundWire (SDW) topology, wiring DTS processing into speaker and jack playback paths and enabling DTS module packaging/build support.

Changes:

Add new DTS-specific SDW amp/jack topology configuration files and select them via SDW_*_PIPELINE_SRC=dts.
Introduce a new reusable mixout-gain-eqiir-dts-alh-dai-copier-playback pipeline class and register it in cavs-sdw.conf.
Enable DTS module inclusion for PTL rimage config and extend DTS llext build rules.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/topology/topology2/production/tplg-targets-ace3.cmake	Adds a PTL RT721+RT1320 DTS topology target preset.
tools/topology/topology2/platform/intel/sdw-jack-dts.conf	New DTS-enhanced SDW jack pipelines and routing.
tools/topology/topology2/platform/intel/sdw-amp-dts.conf	New DTS-enhanced SDW amp (speaker) pipelines and routing.
tools/topology/topology2/include/pipelines/cavs/mixout-gain-eqiir-dts-alh-dai-copier-playback.conf	New pipeline class combining mixout/gain/eqiir/DTS/alh-copier.
tools/topology/topology2/cavs-sdw.conf	Registers the new pipeline include and selects DTS-specific configs.
tools/rimage/config/ptl.toml.h	Includes DTS toml when DTS codec is enabled/modular.
src/audio/codec/dts/llext/CMakeLists.txt	Adds linking for modular DTS llext builds.
src/audio/codec/dts/dts.toml	Increases DTS module `IBS` to 2048.
src/audio/codec/CMakeLists.txt	Fixes conditional structure for DTS codec selection.
app/overlays/ptl/dts_overlay.conf	Adds PTL overlay options to enable DTS and required components.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-03T11:38:30Z

+ {
+ source eqiir.$index.1
+ sink dts.$index.1
+ }


The pipeline routing stops at dts.$index.1 and never connects to alh-copier, so audio won’t reach the DAI stage. Add the missing route entry connecting the DTS widget output to the ALH copier input (consistent with how other playback pipelines terminate at alh-copier).
Suggested change
}
}
{
source dts.$index.1
sink alh-copier.$index.1
}

I've checked for other similar files. There are no route to alh-copier in those files explicitly. This is likely handled by the topology framework.

johnylin76 · 2026-04-05T07:03:30Z

 DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,JACK_RATE=96000,DEEP_BUF_JACK_RATE=96000"

+# RT721 for DTS
+"cavs-sdw\;sof-ptl-rt721-l3-rt1320-l3-dts\;PLATFORM=ptl,NUM_SDW_AMP_LINKS=1,NUM_DMICS=4,\


I didn't find a sof-ptl-rt721-l3-rt1320-l3 build here. Which topology is derived from? (i.e. the same audio codec configuration but without DTS)

@johnylin76
This is provided by Mac. @macchian could you please help to comment on this? Thanks.

@joechengxperi, @johnylin76 , to be updated the specific topology name due to 3rd party pipeline be included instead of functional topology.

For the SOF build structure on our device, we will prepare both common and 3rd-party solution topologies of the same codec spec, i.e. sof-ptl-rt721-l3-rt1320-l3.tplg and sof-ptl-rt721-l3-rt1320-l3-dts.tplg.
sof-ptl-rt721-l3-rt1320-l3.tplg is installed onto
/vendor/firmware/**/sof-tplg/sof-ptl-rt721-l3-rt1320-l3.tplg
sof-ptl-rt721-l3-rt1320-l3-dts.tplg is installed onto
/vendor/firmware/**/sof-tplg/device/sof-ptl-rt721-l3-rt1320-l3.tplg

@johnylin76
Sure, I'll add it.

@joechengxperi , please refer to this topology #10708
This also requires kernel PR:
thesofproject/linux#5739

lyakh

nice!

kv2019i

A few minor comments inline, please check (along with copilot review comments).

kv2019i · 2026-04-08T12:19:17Z

+ "false" {
+ Object.Base.route [
+ {
+ source "gain.21.1"


@bardliao Shouldn't this be "dts.21.1" (instead of "gain.21.1") if enhanced playback is set and DTS is included in the graph. Or doesn't this matter for the virtual link (same problem in sdw-amp-dts.conf)?

@bardliao is there any comment on this? Thanks.

@kv2019i @joechengxperi Sorry for the late reply. It doesn't matter because it is virtual DAI. But when I see the topology graph, there seems be 2 routes from gain.1.1 to eqiir.1.1 to dts.1.1.

Could you double check it?

Update CMakefile and toml to support building DTS to llext module Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

Increase the max parameter size to 2048 Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-14T06:03:36Z

+SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\
+PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-rt721-l3-rt1320-l3-4ch.bin,\
+DMIC0_ENHANCED_CAPTURE=true,EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\
+DEEP_BUF_SPK=true,BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\


This target sets DEEP_BUF_SPK=true but does not set DEEPBUFFER_FW_DMA_MS. In sdw-jack-dts.conf the deep-buffer config is only included when DEEPBUFFER_FW_DMA_MS matches 1-1000ms, so the deep-buffer speaker instance won’t be generated as-is. Either add DEEPBUFFER_FW_DMA_MS (e.g. 10) or drop DEEP_BUF_SPK=true for this target to avoid a non-functional/misleading configuration.
Suggested change
DEEP_BUF_SPK=true,BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\
DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\

@macchian I'll add DEEPBUFFER_FW_DMA_MS=10. Let me know if it shouldn't be.

lgirdwood · 2026-04-16T13:55:29Z

@joechengxperi are you able to respond to any copilot comments so we can dismiss or merge AI inputs with the PR. Thanks !

kv2019i

All my comments addressed, thanks!

joechengxperi · 2026-04-21T09:02:40Z

This commit Topology2 : add DTS topology to support PTL will be removed from this PR by @macchian request. And will create another PR for this commit after PR #10708 is merged
cc @johnylin76

johnylin76

LGTM

app : overlays : add dts overlay for PTL
e74050d
This patch adds DTS_CODEC for Intel PTL platform builds. Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

CopilotAI review requested due to automatic review settings April 3, 2026 11:31

joechengxperi requested review from dbaluta, jsarha, kv2019i, lbetlej, lgirdwood, mmaka1, plbossart and ranj063 as code owners April 3, 2026 11:31

joechengxperi requested review from johnylin76 and macchian April 3, 2026 11:31

Copilotstarted reviewing on behalf of joechengxperi April 3, 2026 11:37 View session

CopilotAI reviewed Apr 3, 2026
View reviewed changes

johnylin76 reviewed Apr 5, 2026
View reviewed changes

lyakh reviewed Apr 7, 2026
View reviewed changes

Comment threadsrc/audio/codec/CMakeLists.txt Outdated

kv2019i reviewed Apr 8, 2026
View reviewed changes

joechengxperi added 2 commits April 14, 2026 11:48

codec : dts : update cmakefile and toml for llext
535d866
Update CMakefile and toml to support building DTS to llext module Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

codec : dts : update the max parameter size
5fe3939
Increase the max parameter size to 2048 Signed-off-by: Joe Cheng <joe.cheng@xperi.com>

joechengxperi force-pushed the main-dts-ptl-merge branch 2 times, most recently from 22cd285 to 58b4b15Compare April 14, 2026 04:06

joechengxperi requested a review from Copilot April 14, 2026 05:56

Copilotstarted reviewing on behalf of joechengxperi April 14, 2026 05:56 View session

CopilotAI reviewed Apr 14, 2026
View reviewed changes

joechengxperi force-pushed the main-dts-ptl-merge branch 2 times, most recently from 8269e4f to f6cf4c3Compare April 19, 2026 10:49

kv2019i approved these changes Apr 20, 2026
View reviewed changes

joechengxperi force-pushed the main-dts-ptl-merge branch from f6cf4c3 to 5fe3939Compare April 21, 2026 09:19

joechengxperi requested a review from johnylin76 April 21, 2026 09:19

johnylin76 approved these changes Apr 21, 2026
View reviewed changes

kv2019i merged commit a5f431c into thesofproject:mainApr 21, 2026
42 of 43 checks passed

joechengxperi mentioned this pull request Apr 22, 2026
Topology2 : add DTS topology to support PTL #10715
Merged

- }
+ }
+ {
+ source dts.$index.1
+ sink alh-copier.$index.1
+ }

	DEEP_BUF_SPK=true,BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\
	DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true,BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true,\

Uh oh!

Conversation

joechengxperi commented Apr 3, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAIApr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lyakh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAIApr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Apr 16, 2026

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

joechengxperi commented Apr 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnylin76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

joechengxperi commented Apr 21, 2026•
edited
Loading