Skip to content

ASoC: SOF: remove superfluous initialization - #766

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
ranj063:fix/upstream1
Apr 4, 2019
Merged

ASoC: SOF: remove superfluous initialization#766
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
ranj063:fix/upstream1

Conversation

@ranj063

@ranj063ranj063 commented Apr 2, 2019

Copy link
Copy Markdown
Collaborator

remove superfluous initialization everywhere based on Takashi's
comments

Not sure if I overdid this. Can I request for this to be checked?

bardliao
bardliao requested changes Apr 2, 2019
View reviewed changes

@bardliaobardliao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be over killed. I am not sure will compiler guarantee all uninitialized value will be 0/null. If not, there are some variable should keep initialized.

Comment threadsound/soc/sof/hw-spi.c Outdated
Comment threadsound/soc/sof/intel/bdw.c Outdated
Comment threadsound/soc/sof/intel/byt.c Outdated
Comment threadsound/soc/sof/intel/hda-ctrl.c Outdated
Comment threadsound/soc/sof/intel/hda-ipc.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
lyakh
lyakh requested changes Apr 2, 2019
View reviewed changes

@lyakhlyakh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm...

Comment threadsound/soc/sof/hw-spi.c Outdated
Comment threadsound/soc/sof/intel/bdw.c Outdated
Comment threadsound/soc/sof/intel/bdw.c Outdated
Comment threadsound/soc/sof/intel/byt.c Outdated
Comment threadsound/soc/sof/intel/byt.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
Comment threadsound/soc/sof/topology.c Outdated
@ranj063

ranj063 commented Apr 2, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Thanks @lyakh and @bardliao I'll fix these up today.

@ranj063

ranj063 commented Apr 2, 2019

Copy link
Copy Markdown
CollaboratorAuthor

@lyakh@bardliao updated based on your comments now.

@ranj063ranj063 changed the title [RFC]ASoC: SOF: remove superfluous initializationASoC: SOF: remove superfluous initializationApr 2, 2019
@plbossart

plbossart commented Apr 3, 2019

Copy link
Copy Markdown
Member

@ranj063 looks good, but the topology parts need to be updated now that we use the process and not effects. Can you rebase and resubmit?

@ranj063

ranj063 commented Apr 3, 2019

Copy link
Copy Markdown
CollaboratorAuthor

@ranj063 looks good, but the topology parts need to be updated now that we use the process and not effects. Can you rebase and resubmit?

@plbossart done

@plbossart

plbossart commented Apr 3, 2019

Copy link
Copy Markdown
Member

@ranj063 looks good, but the topology parts need to be updated now that we use the process and not effects. Can you rebase and resubmit?

@plbossart done

failed build?

@ranj063

ranj063 commented Apr 3, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

hmm there're a couple of sparse issue. Let me check today.

@ranj063
ASoC: SOF: remove all superfluous initialization
81c8815
Based on Takashi's feedback.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063

ranj063 commented Apr 3, 2019

Copy link
Copy Markdown
CollaboratorAuthor

@plbossart all tests passed now.

plbossart
plbossart approved these changes Apr 4, 2019
View reviewed changes

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ranj063

@plbossart
plbossart merged commit d9399e7 into thesofproject:topic/sof-devApr 4, 2019
@ranj063
ranj063 deleted the fix/upstream1 branch April 5, 2019 05:52
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
@jerrykcode@gregkh
staging: vme_user: Fix checkpatch warnings in vme_tsi148.c
f13bd29
This patch fix the follwing checkpatch warnings:
WARNING: quoted string split across lines
thesofproject#129: FILE: drivers/staging/vme_user/vme_tsi148.c:129:
+ dev_err(tsi148_bridge->parent, "VME Mailbox %d received"
+ ": 0x%x\n", i, val);
WARNING: quoted string split across lines
thesofproject#147: FILE: drivers/staging/vme_user/vme_tsi148.c:147:
+	dev_err(tsi148_bridge->parent, "PCI Exception at address: 0x%08x:%08x, "
+ "attributes: %08x\n",
WARNING: quoted string split across lines
thesofproject#153: FILE: drivers/staging/vme_user/vme_tsi148.c:153:
+	dev_err(tsi148_bridge->parent, "PCI-X attribute reg: %08x, PCI-X split "
+ "completion reg: %08x\n",
WARNING: quoted string split across lines
thesofproject#185: FILE: drivers/staging/vme_user/vme_tsi148.c:185:
+ dev_err(tsi148_bridge->parent, "VME Bus Exception Overflow "
+ "Occurred\n");
WARNING: quoted string split across lines
thesofproject#321: FILE: drivers/staging/vme_user/vme_tsi148.c:321:
+ dev_err(tsi148_bridge->parent, "Can't get assigned pci irq "
+ "vector %02X\n", pdev->irq);
WARNING: quoted string split across lines
thesofproject#533: FILE: drivers/staging/vme_user/vme_tsi148.c:533:
+ dev_err(tsi148_bridge->parent, "Invalid PCI Offset "
+ "alignment\n");
WARNING: space prohibited before semicolon
thesofproject#591: FILE: drivers/staging/vme_user/vme_tsi148.c:591:
+ temp_ctl |= TSI148_LCSR_ITAT_SUPR ;
WARNING: quoted string split across lines
thesofproject#766: FILE: drivers/staging/vme_user/vme_tsi148.c:766:
+ dev_err(tsi148_bridge->parent, "Failed to allocate mem "
+ "resource for window %d size 0x%lx start 0x%lx\n",
WARNING: quoted string split across lines
thesofproject#831: FILE: drivers/staging/vme_user/vme_tsi148.c:831:
+ dev_err(tsi148_bridge->parent, "Invalid VME Window "
+ "alignment\n");
WARNING: quoted string split across lines
thesofproject#838: FILE: drivers/staging/vme_user/vme_tsi148.c:838:
+ dev_err(tsi148_bridge->parent, "Size must be non-zero for "
+ "enabled windows\n");
WARNING: quoted string split across lines
thesofproject#853: FILE: drivers/staging/vme_user/vme_tsi148.c:853:
+ dev_err(tsi148_bridge->parent, "Unable to allocate memory for "
+ "resource\n");
WARNING: quoted string split across lines
thesofproject#894: FILE: drivers/staging/vme_user/vme_tsi148.c:894:
+ dev_err(tsi148_bridge->parent, "Invalid VME Offset "
+ "alignment\n");
WARNING: quoted string split across lines
thesofproject#941: FILE: drivers/staging/vme_user/vme_tsi148.c:941:
+ dev_warn(tsi148_bridge->parent, "Currently not setting "
+ "Broadcast Select Registers\n");
WARNING: quoted string split across lines
thesofproject#1455: FILE: drivers/staging/vme_user/vme_tsi148.c:1455:
+ dev_err(dev, "Currently not setting Broadcast Select "
+ "Registers\n");
WARNING: quoted string split across lines
thesofproject#1554: FILE: drivers/staging/vme_user/vme_tsi148.c:1554:
+ dev_err(dev, "Currently not setting Broadcast Select "
+ "Registers\n");
WARNING: quoted string split across lines
thesofproject#1643: FILE: drivers/staging/vme_user/vme_tsi148.c:1643:
+ dev_err(tsi148_bridge->parent, "Descriptor not aligned to 8 "
+ "byte boundary as required: %p\n",
WARNING: else is not generally useful after a break or return
thesofproject#1830: FILE: drivers/staging/vme_user/vme_tsi148.c:1830:
+ return -EBUSY;
+	} else {
warning: quoted string split across lines
thesofproject#1939: file: drivers/staging/vme_user/vme_tsi148.c:1939:
+ dev_err(tsi148_bridge->parent, "location monitor "
+ "callback attached, can't reset\n");
WARNING: space prohibited before semicolon
thesofproject#1964: FILE: drivers/staging/vme_user/vme_tsi148.c:1964:
+ lm_ctl |= TSI148_LCSR_LMAT_SUPR ;
WARNING: quoted string split across lines
thesofproject#2055: FILE: drivers/staging/vme_user/vme_tsi148.c:2055:
+ dev_err(tsi148_bridge->parent, "Location monitor not properly "
+ "configured\n");
WARNING: quoted string split across lines
thesofproject#2200: FILE: drivers/staging/vme_user/vme_tsi148.c:2200:
+ dev_err(tsi148_bridge->parent, "Failed to allocate memory for "
+ "CR/CSR image\n");
WARNING: quoted string split across lines
thesofproject#2241: FILE: drivers/staging/vme_user/vme_tsi148.c:2241:
+ dev_err(tsi148_bridge->parent, "Configuring flush image"
+ " failed\n");
Signed-off-by: Mingyi Kang <jerrykang026@gmail.com>
Link: https://lore.kernel.org/r/20220730045726.55452-1-jerrykang026@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh requested changes
@bardliaobardliaobardliao requested changes
@plbossartplbossartplbossart approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ranj063@plbossart@lyakh@bardliao