Uh oh!
There was an error while loading. Please reload this page.
platform: imx: Implement panic routine - #3282
Conversation
0ff951d to
b1d8a2bCompareUh oh!
There was an error while loading. Please reload this page.
paulstelian97
left a comment
There was a problem hiding this comment.
Will approve once you handle @dbaluta's comments and you link to the corresponding kernel side PR.
b1d8a2b to
e0f037dCompare
paulstelian97
left a comment
There was a problem hiding this comment.
Firmware code looks good, but I need to see kernel code as well. Should be simple enough I guess but I still want to see it.
IulianOlaru249
commented
Aug 10, 2020
This is the patch that will introduce the functions which will handle this panic code on the kernel side: thesofproject/linux#2348. Still needs a bit of work though. |
paulstelian97
commented
Aug 10, 2020
When kernel side looks good this can also be merged then. |
This patch adds logic for the platform_panic() function, called in case of a DSP oops. This is important because it add a panic code in the debug box so the application processor can understand why the oops happened. Also in notifies the application processor about the oops generating an interrupt. Signed-off-by: Iulian Olaru <iulianolaru249@yahoo.com>
e0f037d to
d334d98Comparelgirdwood
commented
Aug 10, 2020
@dbaluta pending CI now, Btw - when will we see NXP CI is the list above ? |
dbaluta
commented
Aug 10, 2020
@lgirdwood cannot provide an ETA, we have an internal CI which runs SOF tests. We started discussions with QA some times ago, but they are stalled. |
lgirdwood
commented
Aug 10, 2020
@dbaluta ok great - just wary of patches that may break IMX, please shout though with any regressions that can be bisected. |
dbaluta
commented
Aug 10, 2020
@lgirdwood btw, when there will be v1.6 release? |
lgirdwood
commented
Aug 10, 2020
@dbaluta I think we are looking at September, we've had some disruption to test and validation cadence due to covid. Can you create topic on TSC discussion and we can the talk about features and schedule. |
This patch adds logic for the platform_panic() function, called in case
of a DSP Oops.
This is important because it add a panic code in the debug box so the
application processor can understand why the Oops happened. Also in
notifies the application processor about the Oops generating an interrupt.
Signed-off-by: Iulian Olaru iulianolaru249@yahoo.com