Skip to content

Asoc: SOF: imx: Add debug support for imx platforms - #2348

Merged
kv2019i merged 1 commit into
thesofproject:topic/sof-devfrom
IulianOlaru249:imx_dump_debug
Aug 25, 2020
Merged

Asoc: SOF: imx: Add debug support for imx platforms#2348
kv2019i merged 1 commit into
thesofproject:topic/sof-devfrom
IulianOlaru249:imx_dump_debug

Conversation

@IulianOlaru249

@IulianOlaru249IulianOlaru249 commented Aug 8, 2020

Copy link
Copy Markdown

This patch adds debug support for imx platforms. This is important in
order to gather information about the state of the DSP in case of an
Oops and the reason for the Oops.

This is done by checking if a message with a panic code has been placed
in the debug box, in the imx8_dsp_handle_request function from sof/imx.

If positive, the function imx8_dump, added in common, will be called.
The first step is to gather information about the registers, filename,
line number and stack by calling the imx8_get_registers, added in common.
Then the information will be printed to the console by calling the
get_status function.

Signed-off-by: Iulian Olaru iulianolaru249@yahoo.com

lyakh
lyakh requested changes Aug 10, 2020
View reviewed changes

@lyakhlyakh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of cosmetic improvements

Comment threadsound/soc/sof/imx/common.c Outdated
Comment threadsound/soc/sof/imx/common.c Outdated
Comment threadsound/soc/sof/imx/imx8.c Outdated
Comment threadsound/soc/sof/imx/imx8m.c Outdated
dbaluta
dbaluta reviewed Aug 10, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/common.c
dbaluta
dbaluta reviewed Aug 10, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/common.c Outdated
dbaluta
dbaluta reviewed Aug 10, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/Makefile
dbaluta
dbaluta reviewed Aug 10, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/Makefile
@IulianOlaru249IulianOlaru249 mentioned this pull request Aug 10, 2020
Merged
@IulianOlaru249IulianOlaru249 changed the title [DO NOT MERGE] Asoc: SOF: imx: Add debug support for imx platformsAsoc: SOF: imx: Add debug support for imx platformsAug 18, 2020
dbaluta
dbaluta reviewed Aug 18, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/common.c Outdated
dbaluta
dbaluta reviewed Aug 18, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/common.c
dbaluta
dbaluta reviewed Aug 19, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/common.h
@IulianOlaru249
IulianOlaru249force-pushed the imx_dump_debug branch 2 times, most recently from 51fde80 to a63324cCompareAugust 19, 2020 12:38
dbaluta
dbaluta reviewed Aug 19, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/imx8.c
dbaluta
dbaluta reviewed Aug 19, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/imx8m.c
dbaluta
dbaluta reviewed Aug 19, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/imx8.c
kv2019i
kv2019i requested changes Aug 19, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IulianOlaru249 ! Looks pretty good. A few minor nitpicks.

Comment threadsound/soc/sof/imx/imx-common.h
Comment threadsound/soc/sof/imx/imx8.c Outdated
Comment threadsound/soc/sof/imx/imx8.c Outdated
dbaluta
dbaluta reviewed Aug 19, 2020
View reviewed changes
Comment threadsound/soc/sof/imx/imx-common.c
dbaluta
dbaluta previously approved these changes Aug 20, 2020
View reviewed changes
kv2019i
kv2019i requested changes Aug 20, 2020
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IulianOlaru249 . The empty lines in middle of local variable declarations is still there. This is very, very minor, but better to fix to keep consistency, so please address.

Comment threadsound/soc/sof/imx/imx8m.c Outdated
Comment threadsound/soc/sof/imx/imx8.c Outdated
@IulianOlaru249
ASoC: SOF: imx: Add debug support for imx platforms
39cdee6
This patch adds debug support for imx platforms. This is important in
order to gather information about the state of the DSP in case of an
oops and the reason for the oops.
This is done by checking if a message with a panic code has been placed
in the debug box, in the imx8_dsp_handle_request function from sof/imx.
If positive, the function imx8_dump, added in common, will be called.
The first step is to gather information about the registers, filename,
line number and stack by calling the imx8_get_registers, added in common.
Then the information will be printed to the console by calling the
get_status function.
Signed-off-by: Iulian Olaru <iulianolaru249@yahoo.com>
@kv2019i
kv2019i merged commit 3d8ae5f into thesofproject:topic/sof-devAug 25, 2020
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
@kirankrishnappa-intel@holtmann
Bluetooth: Fix alt settings for incoming SCO with transparent coding …
06d213d
…format
For incoming SCO connection with transparent coding format, alt setting
of CVSD is getting applied instead of Transparent.
Before fix:
< HCI Command: Accept Synchron.. (0x01|0x0029) plen 21 thesofproject#2196 [hci0] 321.342548
Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd)
Transmit bandwidth: 8000
Receive bandwidth: 8000
Max latency: 13
Setting: 0x0003
Input Coding: Linear
Input Data Format: 1's complement
Input Sample Size: 8-bit
# of bits padding at MSB: 0
Air Coding Format: Transparent Data
Retransmission effort: Optimize for link quality (0x02)
Packet type: 0x003f
HV1 may be used
HV2 may be used
HV3 may be used
EV3 may be used
EV4 may be used
EV5 may be used
> HCI Event: Command Status (0x0f) plen 4 thesofproject#2197 [hci0] 321.343585
Accept Synchronous Connection Request (0x01|0x0029) ncmd 1
Status: Success (0x00)
> HCI Event: Synchronous Connect Comp.. (0x2c) plen 17 thesofproject#2198 [hci0] 321.351666
Status: Success (0x00)
Handle: 257
Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd)
Link type: eSCO (0x02)
Transmission interval: 0x0c
Retransmission window: 0x04
RX packet length: 60
TX packet length: 60
Air mode: Transparent (0x03)
........
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2336 [hci0] 321.383655
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#2337 [hci0] 321.389558
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2338 [hci0] 321.393615
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2339 [hci0] 321.393618
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2340 [hci0] 321.393618
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#2341 [hci0] 321.397070
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2342 [hci0] 321.403622
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2343 [hci0] 321.403625
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2344 [hci0] 321.403625
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2345 [hci0] 321.403625
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#2346 [hci0] 321.404569
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#2347 [hci0] 321.412091
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2348 [hci0] 321.413626
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2349 [hci0] 321.413630
> SCO Data RX: Handle 257 flags 0x00 dlen 48 thesofproject#2350 [hci0] 321.413630
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#2351 [hci0] 321.419674
After fix:
< HCI Command: Accept Synchronou.. (0x01|0x0029) plen 21 thesofproject#309 [hci0] 49.439693
Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd)
Transmit bandwidth: 8000
Receive bandwidth: 8000
Max latency: 13
Setting: 0x0003
Input Coding: Linear
Input Data Format: 1's complement
Input Sample Size: 8-bit
# of bits padding at MSB: 0
Air Coding Format: Transparent Data
Retransmission effort: Optimize for link quality (0x02)
Packet type: 0x003f
HV1 may be used
HV2 may be used
HV3 may be used
EV3 may be used
EV4 may be used
EV5 may be used
> HCI Event: Command Status (0x0f) plen 4 thesofproject#310 [hci0] 49.440308
Accept Synchronous Connection Request (0x01|0x0029) ncmd 1
Status: Success (0x00)
> HCI Event: Synchronous Connect Complete (0x2c) plen 17 thesofproject#311 [hci0] 49.449308
Status: Success (0x00)
Handle: 257
Address: 1C:CC:D6:E2:EA:80 (Xiaomi Communications Co Ltd)
Link type: eSCO (0x02)
Transmission interval: 0x0c
Retransmission window: 0x04
RX packet length: 60
TX packet length: 60
Air mode: Transparent (0x03)
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#312 [hci0] 49.450421
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#313 [hci0] 49.457927
> HCI Event: Max Slots Change (0x1b) plen 3 thesofproject#314 [hci0] 49.460345
Handle: 256
Max slots: 5
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#315 [hci0] 49.465453
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#316 [hci0] 49.470502
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#317 [hci0] 49.470519
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#318 [hci0] 49.472996
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#319 [hci0] 49.480412
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#320 [hci0] 49.480492
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#321 [hci0] 49.487989
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#322 [hci0] 49.490303
< SCO Data TX: Handle 257 flags 0x00 dlen 60 thesofproject#323 [hci0] 49.495496
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#324 [hci0] 49.500304
> SCO Data RX: Handle 257 flags 0x00 dlen 60 thesofproject#325 [hci0] 49.500311
Signed-off-by: Kiran K <kiran.k@intel.com>
Signed-off-by: Lokendra Singh <lokendra.singh@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbalutadbalutadbaluta approved these changes
@lyakhlyakhlyakh approved these changes
@kv2019ikv2019ikv2019i approved these changes
@bardliaobardliaoAwaiting requested review from bardliaobardliao is a code owner
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@ranj063ranj063Awaiting requested review from ranj063ranj063 is a code owner
+1 more reviewer
@paulstelian97paulstelian97paulstelian97 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IulianOlaru249@dbaluta@lyakh@paulstelian97@kv2019i