Uh oh!
There was an error while loading. Please reload this page.
Fix -Werror=declaration-after-statement and add flag - #3995
Conversation
986d972 to
d0803e8Comparecujomalainey
commented
Mar 31, 2021
Thanks for the fixes, i just have one nit, that the fixes and the flag change be two separate patches. Otherwise LGTM |
Will make git commands (blame, merge, revert, rebase, cherry-pick,...) much less likely to fail. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Do not add the option yet. Automate current (and unwritten?) coding guidelines. Let's not waste considerable time in code reviews discussing problems computers can catch automatically. Note this goes against CERT-C recommendations DCL00-C, DCL19-C and many others but it's the current policy so let's apply and automate it. Can be changed later. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Automate current (and unwritten?) coding guidelines. Let's not waste considerable time in code reviews discussing problems computers can catch automatically. Note this goes against CERT-C recommendations DCL00-C, DCL19-C and many others but it's the current policy so let's apply and automate it. Can be changed later. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
Apr 1, 2021
3 commits for you sir! |
cujomalainey
left a comment
There was a problem hiding this comment.
Thanks more bot info always a win 👍
lgirdwood
commented
Apr 1, 2021
@marc-hb can you check CI, this should not break UT (unless it break UT build) ? |
Downgrading to draft for now. |
sys-pt1s
commented
Apr 20, 2022
Can one of the admins verify this patch? |
kv2019i
commented
Apr 20, 2022
@marc-hb Over a year with no activity, keep open? |
marc-hb
commented
Apr 20, 2022
The Linux kernel has moved to C99 (even higher actually but not relevant here), we should do the same. Closing |
Automate current (and unwritten?) coding guidelines. Let's not waste
considerable time in code reviews discussing problems computers can
catch automatically.
Note this goes against CERT-C recommendations DCL00-C, DCL19-C and many
others but it's the current policy so let's apply and automate it. Can
be changed later.
Signed-off-by: Marc Herbert marc.herbert@intel.com