sof-ctl: Fix -Wformat,-Wsometimes-uninitialized

[afq984]

• Use %z specifier for size types to avoid format
  specifier warnings on arm32
• in ctl_dump(), size_t n may be used uninitialized
  if ctl_data->out_fd > 0 and !ctl_data->binary.

Signed-off-by: Li-Yu Yu aaronyu@google.com

[lgirdwood]

@dbaluta@paulstelian97 any comments ?

[marc-hb]

BTW this is exactly why requesting declarations to be at the top of the function is harmful. This practice should be banned. If size_t n had been declared inside the if (ctl_data->binary) block where it is used locally then the compiler would have immediately found this error.

Pre-C99 does not even require declarations to be at the top of a function, it only requires them to be at the top of a block.

SOF always had ("accidental") declaration-after-statement in a number of places (#3995) and no compiler even complained about that.

Even the Linux kernel moved beyond C89: https://lwn.net/Articles/885941/

And of course no other programming language requires anything like this.