Update fuzzer build in CI to use oss-fuzz tooling by cujomalainey · Pull Request #4132 · thesofproject/sof

cujomalainey · 2021-05-03T22:14:16Z

Do full fuzzer build as part of the CI

Also consolidate all yamlint actions into a single job

marc-hb · 2021-05-03T23:14:32Z

Have you considered moving this to a new yamllint.yml file? With hindsight I think using one big file for everything was a Github Action beginner mistake.

I have nothing against it. i just figured it would make more sense to patch sanity check tools into the same workflow "yamllint, checkpatch, pep8, etc.." thoughts? I agree things like build tools or actual builds should be separate files

I just figured it would make more sense to patch sanity check tools into the same workflow "yamllint, checkpatch, pep8, etc.." thoughts?
Why not, in that case maybe change the titles a bit because right now this is called "checkpatch" at every level: workflow, job and what not. Warning: github actions "headings" look slightly different in merged vs unmerged PRs, have a look at one example of each.

marc-hb

We need the yamllint warning fixed unfortunately.

marc-hb · 2021-05-04T01:50:21Z

I just figured it would make more sense to patch sanity check tools into the same workflow "yamllint, checkpatch, pep8, etc.." thoughts?
Why not, in that case maybe change the titles a bit because right now this is called "checkpatch" at every level: workflow, job and what not. Warning: github actions "headings" look slightly different in merged vs unmerged PRs, have a look at one example of each.

lgirdwood · 2021-05-05T13:18:21Z

Lets get this in rc2.

gkbldcig · 2021-05-10T04:20:10Z

Can one of the admins verify this patch?

lgirdwood · 2021-05-10T08:56:40Z

please test this

cujomalainey · 2021-05-10T22:39:01Z

please test this

if CI passes it works, will fixup issues this week, last week got last minute sheriff rotation that overtook my time

lgirdwood · 2021-05-12T08:20:49Z

please test this
if CI passes it works, will fixup issues this week, last week got last minute sheriff rotation that overtook my time

hehe, sorry - I was speaking to the CI here as it was refusing to runt tests for some reason.
No worries, we can get this for rc2.

cujomalainey · 2021-05-14T01:08:18Z

Again, apologies for the delay, was blocked internally

marc-hb

One last yamllint warning

cujomalainey · 2021-05-18T01:26:11Z

@lgirdwood looks like we will need to update the protected branches rules after this as some of the jobs might not match

marc-hb

And now yamllint seems stuck in the summary, it cursed this PR!

A closer look in the "checks" tab shows it has actually run and passed, only the status is missing: https://github.com/thesofproject/sof/pull/4132/checks?check_run_id=2606149741

cujomalainey · 2021-05-18T05:35:32Z

@marc-hb im pretty sure it didnt actually run because it is looking for this job, we need update the protected branches matches

I'm not sure why the summary did not update but for sure the check itself ran. Quoting https://github.com/thesofproject/sof/pull/4132/checks?check_run_id=2606149741:
Note: switching to 'refs/remotes/pull/4132/merge'. HEAD is now at ed6ce7a Merge b5b59e7ef0261560d51b1e164785dae62bcda41c into f510435a253373c806c49fbc32d876287bcbe801
b5b59e7ef0261 is the last commit you pushed.

Yes that is the new yamllint job I added which is codestyle / yamllint which is also showing up below. It is stuck on yamllint /.github/workflows/ which you can see is the name of the above deleted job. I think its stuck because the protected branch requires it.

I keep looking but I don't see anything stuck sorry, I only see the status not updated in the summary.
( https://github.com/thesofproject/sof/runs/2607493012?check_suite_focus=true ran again fine and the status was not updated again)

Sorry I get it now: missed the difference between the new yamllint check and the old yamllint check. Only the removed check is "stuck" which is maybe only because it's getting removed and does not exist anymore. I bet this will fix itself and just go away once this PR is merged.

Sorry I get it now: missed the difference between the new yamllint check and the old yamllint check. Only the removed check is "stuck" which is maybe only because it's getting removed and does not exist anymore. I bet this will fix itself and just go away once this PR is merged.
Looks like it "fixed itself", the old yamllint is now gone, see for instance #4211 and others. Let's assume github struggles a bit during the transition when renaming some Actions files.

I bet it disappeared when i removed the rule to require it. Basically protected branch logic stopped looking for something that no longer exists

Use oss-fuzz infra to make sure we don't break the fuzzer Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

rename scant to ipc as this is the ipc fuzzer Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

Lets not trust that everyone remembers to lint themselves or that they fetch the repo in order to execute their job. Also rename workflow file to be a bit more generic Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

cujomalainey · 2021-05-18T06:04:11Z

Fixed a comment (had a double word)

lgirdwood · 2021-05-18T16:24:16Z

@lgirdwood looks like we will need to update the protected branches rules after this as some of the jobs might not match

@cujomalainey ok, I'll merge now, and everything looks ok atm. What changes would we need to make ?

cujomalainey · 2021-05-18T19:11:12Z

@lgirdwood i fixed settings. Its under settings-> branches -> protected branches rules

lgirdwood · 2021-05-18T19:11:14Z

@cujomalainey is there anyway we can build fuzzer locally ? I've moved some code an now it doesn't build from #4202

/usr/local/bin/clang -DRELATIVE_FILE=\"fuzz_ipc.c\" -I/src/sof/tools/oss-fuzz/build_oss_fuzz/sof_ep/install/include -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -g -O3 -Wall -Werror -Wmissing-prototypes -Wimplicit-fallthrough -DCONFIG_LIBRARY -imacros/src/sof/tools/oss-fuzz/build_oss_fuzz/sof_ep/build/library_autoconfig.h -o CMakeFiles/fuzz_ipc.dir/fuzz_ipc.c.o -c /src/sof/tools/oss-fuzz/fuzz_ipc.c
[100%] Linking C executable /github/workspace/out/fuzz_ipc
/usr/local/bin/cmake -E cmake_link_script CMakeFiles/fuzz_ipc.dir/link.txt --verbose=1
/usr/local/bin/clang++ -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=fuzzer-no-link -fsanitize=fuzzer CMakeFiles/fuzz_ipc.dir/fuzz_ipc.c.o -o /github/workspace/out/fuzz_ipc -Wl,-rpath,::::::::::::::::::::::::::::::::::::::::::::::::::::::::: -ldl -lm sof_ep/install/lib/libsof.a sof_ep/install/lib/libsof.a(dai-ipc3.c.o): In function `dai_config':
/src/sof/src/ipc/dai-ipc3.c:238: undefined reference to `dai_assign_group'
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [/github/workspace/out/fuzz_ipc] Error 1
CMakeFiles/fuzz_ipc.dir/build.make:103: recipe for target '/github/workspace/out/fuzz_ipc' failed
make[2]: Leaving directory '/src/sof/tools/oss-fuzz/build_oss_fuzz'
CMakeFiles/Makefile2:96: recipe for target 'CMakeFiles/fuzz_ipc.dir/all' failed
make[1]: Leaving directory '/src/sof/tools/oss-fuzz/build_oss_fuzz'
make[1]: *** [CMakeFiles/fuzz_ipc.dir/all] Error 2
Makefile:148: recipe for target 'all' failed
make: *** [all] Error 2
2021-05-18 16:55:26,513 - root - ERROR - Building fuzzers failed.
2021-05-18 16:55:26,513 - root - ERROR - Error building fuzzers for project sound-open-firmware (commit: 3694eaded9cc277e02743a361176a8f5d870570e, pr_ref: refs/pull/4202/merge).
Running: docker build -t gcr.io/oss-fuzz/sound-open-firmware projects/sound-open-firmware
Running: docker run --rm --privileged --cap-add SYS_PTRACE -e FUZZING_ENGINE=libfuzzer -e SANITIZER=address -e ARCHITECTURE=x86_64 -e CIFUZZ=True -e FUZZING_LANGUAGE=c++ -e OUT=/github/workspace/out --volumes-from 07abee7ace53 gcr.io/oss-fuzz/sound-open-firmware /bin/bash -c 'rm -rf /src/sof/* && cp -r /github/workspace/storage/sof /src && compile'

cujomalainey · 2021-05-18T19:17:15Z

To build the firmware locally follow this you need the oss-fuzz repo and run the commands in the repo while passing a path pointing to the SOF repo

marc-hb

While cleaning up #4210 I realized only now that the other fuzzer/ directory seems completely unrelated... and README-less. Why do we have two?

marc-hb · 2021-05-18T23:06:44Z

Sorry I get it now: missed the difference between the new yamllint check and the old yamllint check. Only the removed check is "stuck" which is maybe only because it's getting removed and does not exist anymore. I bet this will fix itself and just go away once this PR is merged.
Looks like it "fixed itself", the old yamllint is now gone, see for instance #4211 and others. Let's assume github struggles a bit during the transition when renaming some Actions files.

cujomalainey · 2021-05-18T23:34:03Z

While cleaning up #4210 I realized only now that the other fuzzer/ directory seems completely unrelated... and README-less. Why do we have two?

That was fuzzer v1 which started as a GSoC project. If found a number of bugs but was not scale-able unfortunately. Therefore I rewrote to work with oss-fuzz which is running continuous automatic fuzzing. Also note there are docs on sof-docs.

marc-hb · 2021-05-18T23:59:56Z

Should v1 be deleted or kept with a README?

cujomalainey · 2021-05-19T02:55:06Z

@ranj063 thoughts? Technically oss covers all ipc commands including topology

ranj063 · 2021-05-19T16:51:29Z

@ranj063 thoughts? Technically oss covers all ipc commands including topology

@cujomalainey @marc-hb yes, Im fine with deleting or deprecating v1.

As discussed in thesofproject#4132 Signed-off-by: Marc Herbert <marc.herbert@intel.com>

As discussed in #4132 Signed-off-by: Marc Herbert <marc.herbert@intel.com>

cujomalainey changed the title ~~[DNR] actions: scant fuzzer, add automated build~~Update fuzzer build in CI to use oss-fuzz toolingMay 3, 2021

cujomalainey requested a review from marc-hb May 3, 2021 22:48

cujomalainey marked this pull request as ready for review May 3, 2021 22:49

cujomalainey requested review from dbaluta, lgirdwood and zrombel as code owners May 3, 2021 22:49

marc-hb reviewed May 3, 2021
View reviewed changes

marc-hb requested changes May 4, 2021
View reviewed changes

This was referenced May 4, 2021
oss-fuzz: fix build #4118
Merged
Cppcheck fixes but its for rimage thesofproject/rimage#46
Merged

lgirdwood added this to the v1.8 milestone May 4, 2021

marc-hb mentioned this pull request May 6, 2021
audio: add UT_STATIC to crossover and smart_amp #4148
Merged

cujomalainey requested a review from marc-hb May 14, 2021 01:07

cujomalainey commented May 14, 2021
View reviewed changes

Comment thread.github/workflows/ipc_fuzzer.yml Outdated

marc-hb reviewed May 14, 2021
View reviewed changes

Comment thread.github/workflows/ipc_fuzzer.yml Outdated

marc-hb reviewed May 14, 2021
View reviewed changes

Comment thread.github/workflows/patch_verification.yml Outdated

marc-hb requested changes May 18, 2021
View reviewed changes

Comment thread.github/workflows/ipc_fuzzer.yml Outdated
Comment thread.github/workflows/codestyle.yml Outdated
Comment thread.github/workflows/scant_fuzzer.yml Outdated
Comment thread.github/workflows/codestyle.yml Outdated
Comment thread.github/workflows/codestyle.yml Outdated

marc-hb reviewed May 18, 2021
View reviewed changes

Comment thread.github/workflows/ipc_fuzzer.yml Outdated

marc-hb reviewed May 18, 2021
View reviewed changes

Comment thread.github/workflows/ipc_fuzzer.yml Outdated
Comment thread.github/workflows/ipc_fuzzer.yml Outdated

marc-hb approved these changes May 18, 2021
View reviewed changes

cujomalainey commented May 18, 2021
View reviewed changes

cujomalainey added 2 commits May 17, 2021 23:02

actions: scant fuzzer: refactor CI build
d0002d0
Use oss-fuzz infra to make sure we don't break the fuzzer Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

actions: rename fuzzer job
59b87f7
rename scant to ipc as this is the ipc fuzzer Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

actions: consolidate yamlint
3e001cb
Lets not trust that everyone remembers to lint themselves or that they fetch the repo in order to execute their job. Also rename workflow file to be a bit more generic Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>

lgirdwood approved these changes May 18, 2021
View reviewed changes

lgirdwood merged commit 0a1029c into thesofproject:mainMay 18, 2021

cujomalainey deleted the fuzz branch May 18, 2021 19:08

marc-hb reviewed May 18, 2021
View reviewed changes

marc-hb added a commit to marc-hb/sof that referenced this pull request May 24, 2021
fuzzer: add deprecation README.md
26479c0
As discussed in thesofproject#4132 Signed-off-by: Marc Herbert <marc.herbert@intel.com>

cujomalainey pushed a commit that referenced this pull request May 24, 2021
fuzzer: add deprecation README.md
fa5cc11
As discussed in #4132 Signed-off-by: Marc Herbert <marc.herbert@intel.com>

marc-hb mentioned this pull request Dec 7, 2022
Add native_posix-based Zephyr emulator #6210
Merged

Uh oh!

Conversation

cujomalainey commented May 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented May 5, 2021

Uh oh!

gkbldcig commented May 10, 2021

Uh oh!

lgirdwood commented May 10, 2021

Uh oh!

cujomalainey commented May 10, 2021

Uh oh!

lgirdwood commented May 12, 2021

Uh oh!

cujomalainey commented May 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cujomalainey commented May 18, 2021

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marc-hbMay 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cujomalainey commented May 18, 2021

Uh oh!

lgirdwood commented May 18, 2021

Uh oh!

cujomalainey commented May 18, 2021

Uh oh!

lgirdwood commented May 18, 2021

Uh oh!

cujomalainey commented May 18, 2021

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

cujomalainey commented May 3, 2021•
edited
Loading

marc-hbMay 18, 2021•
edited
Loading

cujomalainey commented May 18, 2021•
edited
Loading