Uh oh!
There was an error while loading. Please reload this page.
add build-tools.sh ALL to github actions, lost with Travis - #4210
Conversation
cb9d516 to
7f8ebb9CompareThere was a problem hiding this comment.
(too) terse allusion to the tools/ subdirectory. How about: User space in tools dir?
There was a problem hiding this comment.
why caps? why not something more informative such as "build check"
There was a problem hiding this comment.
A bit cryptic allusion to the default CMake target and its reserved name ALL, see #4141 for more background.
How about Build ALL?
lgirdwood
commented
May 19, 2021
Fwiw, looks like an unrelated timeout on internal codec checks (but all green). |
gcc does not know that we already filtered unreasonable precision values. Increase the size of the temporary string from 32 bytes to 64 bytes. We're running on the host, memory is cheap. Fixes commit d6f6a45 ("logger: fix column and header alignments") For some reason CMake uses -Werror=format-truncation only in Release mode. Avoids the following warning: ``` sof/tools/logger/convert.c: In function ‘fetch_entry’: sof/tools/logger/convert.c:514:27: error: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size between 0 and 18 [-Werror=format-truncation=] 514 | "%%s[%%%d.%df] (%%%d.%df)%%s ", | ^~ sof/tools/logger/convert.c:514:6: note: directive argument in the range [0, 2147483647] 514 | "%%s[%%%d.%df] (%%%d.%df)%%s ", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/stdio.h:867, from sof/tools/logger/convert.h:13, from sof/tools/logger/convert.c:21: /usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 21 and 59 bytes into a destination of size 32 67 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 68 | __bos (__s), __fmt, __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
We used to do this in Travis, see commit 7072eb4 ("travis: run build-tools.sh with CMAKE_BUILD_TYPE=Release") and older. Related to issue thesofproject#4141 build-tools.sh -T does not build development topologies. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fixesthesofproject#4141. I got tired of repeatedly having to read CMakeLists.txt files. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
May 22, 2021
https://sof-ci.01.org/sofpr/PR4210/build9084/devicetest/?model=CML_HEL_RT5682&testcase=verify-pcm-list had the topology panic below that has also been seen elsewhere. Can't possibly related to building user space tools. I think a recent kernel revert fixed it. Everything else was green for commit 7f8ebb9b507, especially https://sof-ci.01.org/sofpr/PR4210/build9084/build/tools.txt and https://github.com/thesofproject/sof/pull/4210/checks?check_run_id=2615211180 https://github.com/thesofproject/sof/pull/4210/checks?check_run_id=2643711883 is green again and |
lgirdwood
left a comment
There was a problem hiding this comment.
@cujomalainey please merge if you are aligned with the review changes.
Uh oh!
There was an error while loading. Please reload this page.
cujomalainey
commented
May 24, 2021
one comment issue otherwise all good |
As discussed in thesofproject#4132 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
commented
May 24, 2021
A couple hardware issues that cannot be related to this. In the same run APL_UP2_HDA was not available for testing or its kernel failed to boot, not sure which one. Everything else is green including https://sof-ci.01.org/sof-pr-viewer/#/build/PR4210/build6485167 |
cujomalainey
commented
May 24, 2021
Agreed, unrelated |
2 commits related to recent #4141