Skip to content

debugability: pipeline and component ids in trace messages - #530

Merged
lgirdwood merged 4 commits into
thesofproject:masterfrom
akloniex:ids-in-trace
Nov 7, 2018
Merged

debugability: pipeline and component ids in trace messages#530
lgirdwood merged 4 commits into
thesofproject:masterfrom
akloniex:ids-in-trace

Conversation

@akloniex

@akloniexakloniex commented Nov 2, 2018

Copy link
Copy Markdown
Member

In reference to #508

@akloniex

akloniex commented Nov 2, 2018

Copy link
Copy Markdown
MemberAuthor

@lgirdwood I'm aware of conflicts. Please review current progress on this subject, to ensure that we're on the right track before I go full on with changing all trace macros in our project.

lgirdwood
lgirdwood reviewed Nov 2, 2018
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction. Think we can make this a little more generic for other users too.

Comment threadsrc/include/sof/sof.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/uapi/abi.h Outdated
@bkokoszxbkokoszx mentioned this pull request Nov 5, 2018
Merged
lgirdwood
lgirdwood approved these changes Nov 5, 2018
View reviewed changes

@lgirdwoodlgirdwood left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akloniex Lets get all the pieces approved and CI build fixed before merging.

@akloniex

akloniex commented Nov 5, 2018

Copy link
Copy Markdown
MemberAuthor

@lgirdwood Currently build fails on Travis while building host target, due to cast from pointer to uint32_t. As host is built with x64 architecture, this warning seems legit, but I don't know how to work around this.
I could trick the compiler to turn off compile-time type-checking, a.k.a. restore previous behaviour, but it feels like too big of a cost.
I would appreciate your input.

@lgirdwood

lgirdwood commented Nov 5, 2018

Copy link
Copy Markdown
Member

@akloniex you could use uintptr_t instead of uint32_t as the host versions of the trace macros just call printf directly anyway (i.e. we dont use logger on host).

@mwierzbixmwierzbix mentioned this pull request Nov 6, 2018
Merged
@akloniex
akloniexforce-pushed the ids-in-trace branch 7 times, most recently from c75b5c3 to 0e0fc34CompareNovember 6, 2018 11:10
@akloniex
debugability: Add components ids to trace_event macros
9af90ce
2 arbitrary IDs may now be passed to specialized versions of
trace_event macro: trace_event_with_ids. Also optimized runtime
stack usage of _trace_event functions.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex
debugability: Refactor pipeline traces to fully utilize new trace_event
1d559f8
Implemented set of macros for pipelines to allow reporting of pipeline
and component IDs. Refactor all traces to provide useful, human readible
messages.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex
debugability: Refactor ipc handler traces to fully utilize trace_event
8449f24
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex
debugability: Refactor dai traces to fully utilize trace_event
4217992
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@mwierzbix

mwierzbix commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

@lgirdwood@akloniex Yay, all the checks are green now!

@lgirdwood
lgirdwood merged commit 019eade into thesofproject:masterNov 7, 2018
@akloniexakloniex mentioned this pull request Nov 7, 2018
Closed
@keqiaozhangkeqiaozhang mentioned this pull request Nov 8, 2018
Closed
@akloniex
akloniex deleted the ids-in-trace branch January 28, 2019 06:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@mmaka1mmaka1Awaiting requested review from mmaka1
+1 more reviewer
@mwierzbixmwierzbixmwierzbix left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akloniex@lgirdwood@mwierzbix