Skip to content

Deprecate Intel platforms byt..icl post 2.3. Add "rmb" to "-a" - #6227

Merged
lgirdwood merged 4 commits into
thesofproject:mainfrom
marc-hb:deprecated-2.3
Aug 31, 2022
Merged

Deprecate Intel platforms byt..icl post 2.3. Add "rmb" to "-a"#6227
lgirdwood merged 4 commits into
thesofproject:mainfrom
marc-hb:deprecated-2.3

Conversation

@marc-hb

@marc-hbmarc-hb commented Aug 31, 2022

Copy link
Copy Markdown
Collaborator

see commit messages

@marc-hb
xtensa-build-all.sh: add rmb to default platforms built with -a
df674b2
The rmb toolchain was added in commit 4e85dfc ("docker: add
AMD/Rembrandt gcc toolchain") and before.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
xtensa-build-all.sh: remove byt..jsl platforms from '-a'
dccce63
These platforms are not supported in the main branch anymore.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
installer: remove byt..jsl platforms
71cb71f
Not supported in the main branch anymore, go to stable-v2.3
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
.github/qemu,gcc-build-only: remove byt..icl platforms
d7d67cf
Not supported in the main branch anymore, go to stable-v2.3
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
marc-hb marked this pull request as ready for review August 31, 2022 14:29
@marc-hbmarc-hb mentioned this pull request Aug 31, 2022
Closed
@marc-hb

marc-hb commented Aug 31, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I don't understand why there is "phantom" sue jsl tgl line still, see screenshots below.

Maybe because this PR has 4 commits and the following change is only in the last commit? So Github is confused until this is merged?

- sue jsl tgl+ tgl

This phantom line is not present in the results page: https://github.com/thesofproject/sof/runs/8115712163

The same happens in #6223

Screenshot 2022-08-31 at 08 49 24

Screenshot 2022-08-31 at 08 50 16

@lgirdwood
lgirdwood merged commit 0209c46 into thesofproject:mainAug 31, 2022
marc-hb added a commit to marc-hb/sof that referenced this pull request Aug 31, 2022
@marc-hb
TEST IGNORE
47d8b95
Testing github actions after thesofproject#6227 merge
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hbmarc-hb mentioned this pull request Aug 31, 2022
Closed
@marc-hb
marc-hb deleted the deprecated-2.3 branch August 31, 2022 21:15
@marc-hb

marc-hb commented Aug 31, 2022

Copy link
Copy Markdown
CollaboratorAuthor

The phantom line is still there, see #6231. This is crazy.

@marc-hb

marc-hb commented Sep 14, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Problem found and solved, this was all caused by main branch protection rules in https://github.com/thesofproject/sof/settings/branches (which I do not have access to, only admins do)

Removing the corresponding protection rules made the problem instantly go away on all affected PRs (no need to force push or anything).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@cujomalaineycujomalaineyAwaiting requested review from cujomalainey
@aborisovichaborisovichAwaiting requested review from aborisovich
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-hb@lgirdwood