Skip to content

[SKIP CI] TEST phantom check "gcc-build-only (sue jsl tgl)" IGNORE - #6231

Closed
marc-hb wants to merge 1 commit into
thesofproject:mainfrom
marc-hb:gh-test-ignore
Closed

[SKIP CI] TEST phantom check "gcc-build-only (sue jsl tgl)" IGNORE#6231
marc-hb wants to merge 1 commit into
thesofproject:mainfrom
marc-hb:gh-test-ignore

Conversation

@marc-hb

Copy link
Copy Markdown
Collaborator

Testing github actions after #6227 merge

Signed-off-by: Marc Herbert marc.herbert@intel.com

Testing github actions after thesofproject#6227 merge
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hbmarc-hb changed the title [SKIP CI] TEST IGNORE[SKIP CI] TEST phantom gcc-build-only (sue jsl tgl) IGNOREAug 31, 2022
@marc-hbmarc-hb changed the title [SKIP CI] TEST phantom gcc-build-only (sue jsl tgl) IGNORE[SKIP CI] TEST phantom "gcc-build-only (sue jsl tgl)" IGNOREAug 31, 2022
@marc-hb

marc-hb commented Aug 31, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Still a phantom "gcc-build-only (sue jsl tgl)" line after it's been removed from .github/workflows/pull-request.yml in #6227... this is crazy. It's not visible on https://github.com/thesofproject/sof/runs/8122925542?check_suite_focus=true and does not have any Github Action icon?!?

Screenshot 2022-08-31 at 14 13 27

@fredoh9

fredoh9 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

@marc-hb if you are looking at "gcc-build-only (sue jsl tgl)" , it is from jenkins job.
Current GCC platforms to build from local server are byt cht bdw apl cnl icl jsl tgl tgl-h. Don't remember where "sue jsl tgl" are came from.(still searching) You can remove [skip ci] and try again.

@fredoh9

fredoh9 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

gcc-build-only (sue jsl tgl) is not from jenkins task. Sorry for confusion.

@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

Phantom line still present in (unrelated) #6238

marc-hb added a commit to marc-hb/sof that referenced this pull request Sep 1, 2022
test for phantom line, see thesofproject#6231
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hbmarc-hb changed the title [SKIP CI] TEST phantom "gcc-build-only (sue jsl tgl)" IGNORE[SKIP CI] TEST phantom check "gcc-build-only (sue jsl tgl)" IGNORESep 1, 2022
@marc-hb

marc-hb commented Sep 14, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Thanks to a tip I noticed that the phantom and never running check gcc-build-only (sue jsl tgl) is marked as "required" while the newer and shorter version Main Actions / gcc-build-only (tgl) is not!?!

@lgirdwood or any other admin please share the "required checks" that should be found somewhere near https://github.com/thesofproject/sof/settings/branches

@lgirdwood

Copy link
Copy Markdown
Member

@lgirdwood or any other admin please share the "required checks" that should be found somewhere near https://github.com/thesofproject/sof/settings/branches

aha - there was a lingering "check" for jsl which has now been deleted. Lets see if this works for next PRs

@marc-hb

Copy link
Copy Markdown
CollaboratorAuthor

Indeed this was all caused by main branch protection rules in https://github.com/thesofproject/sof/settings/branches.

Removing the corresponding protection rules made the problem instantly go away on all affected PRs (no need to force push or anything).

@marc-hbmarc-hb closed this Sep 14, 2022
@marc-hb
marc-hb deleted the gh-test-ignore branch September 14, 2022 21:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-hb@fredoh9@lgirdwood