Skip to content

Mtl: Add base code to bring up interfaces - #6360

Merged
kv2019i merged 5 commits into
thesofproject:mainfrom
softwarecki:mtl
Oct 18, 2022
Merged

Mtl: Add base code to bring up interfaces#6360
kv2019i merged 5 commits into
thesofproject:mainfrom
softwarecki:mtl

Conversation

@softwarecki

@softwareckisoftwarecki commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

Added clock definitions, dma channels configuration and updated configuration options of the mtl board.

abonislawski
abonislawski requested changes Sep 30, 2022
View reviewed changes
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
abonislawski
abonislawski reviewed Sep 30, 2022
View reviewed changes
Comment threadsrc/platform/intel/ace/lib/clk.c Outdated
Comment threadsrc/platform/meteorlake/lib/clk.c Outdated
@softwarecki
softwareckiforce-pushed the mtl branch 2 times, most recently from 8bc0acf to c209784CompareOctober 3, 2022 13:25
lgirdwood
lgirdwood approved these changes Oct 3, 2022
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wont merge until @abonislawski and @softwarecki are aligned.

@lgirdwood

lgirdwood commented Oct 3, 2022

Copy link
Copy Markdown
Member

ok, pls ping the PR when teh Zephyr change is merged.

abonislawski
abonislawski requested changes Oct 3, 2022
View reviewed changes
Comment threadapp/boards/intel_adsp_ace15_mtpm.conf Outdated
Comment threadapp/boards/intel_adsp_ace15_mtpm.conf Outdated
marcinszkudlinski
marcinszkudlinski requested changes Oct 3, 2022
View reviewed changes
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
kv2019i
kv2019i requested changes Oct 4, 2022
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but looks good otherwise.

Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
Comment threadapp/boards/intel_adsp_ace15_mtpm.conf Outdated
Comment threadapp/boards/intel_adsp_ace15_mtpm.conf Outdated
lyakh
lyakh reviewed Oct 4, 2022
View reviewed changes
Comment threadsrc/platform/intel/ace/lib/clk.c Outdated
Comment threadsrc/platform/intel/ace/lib/dma.c Outdated
@softwarecki

softwarecki commented Oct 5, 2022•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

This PR requires following PR merged in Zephyr:
zephyrproject-rtos/zephyr#49458 ✔️
zephyrproject-rtos/zephyr#48949 ✔️
zephyrproject-rtos/zephyr#51004 ✔️

@lgirdwood

lgirdwood commented Oct 5, 2022

Copy link
Copy Markdown
Member

This PR requires following PR merged in Zephyr: zephyrproject-rtos/zephyr#49458zephyrproject-rtos/zephyr#48949

48949 is now merged, in the meantime can we have an update with the review comments addressed. This will get us ready for the final Zephyr patch being merged. Thanks !

@softwarecki
softwareckiforce-pushed the mtl branch 2 times, most recently from 32617c1 to aa6795dCompareOctober 5, 2022 15:47
kv2019i
kv2019i approved these changes Oct 6, 2022
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @softwarecki !

@lgirdwood

lgirdwood commented Oct 10, 2022

Copy link
Copy Markdown
Member

@softwarecki can you force push again, it looks like CI got stuck. Thanks

@kv2019i

kv2019i commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

@softwarecki@wszypelt License-server issue hit in the CI run.

@marc-hb

marc-hb commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

@softwarecki@wszypelt License-server issue hit in the CI run.

QB or Jenkins? Always copy the URL, it's hard/impossible to find after a force push.

@abonislawski

abonislawski commented Oct 12, 2022

Copy link
Copy Markdown
Member

One required PR left: #6396

Please wait for confirmation that this PR is working with validation tests before merging.

@kv2019i

kv2019i commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

Dependencies now merged. @softwarecki can you resolve the conflict and @abonislawski please review.

@kv2019i

kv2019i commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

@softwarecki@abonislawski ping?

@softwarecki
ace: clock: Update clock definitions
1775ebc
Added code with clock definitions
Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@softwarecki
ace: dma: Add dma configuration
6e0052a
Added code containing configuration of the dma channels.
Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@softwarecki
ace: dma: Add temporary dma ops to allow get attributes
d7df6f4
The attributes of the dma controllers must be moved
to the zephyr. Until then, we will use a own copy of the
get_attribute function from the alh and dw_dma drivers.
Thanks to this, we can completely disable it building
in the configuration.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
@softwarecki
mtl: board: Update mtl board configuration
88d9d88
Necessary configuration options of the mtl board
have been enabled.
Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Signed-off-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@softwarecki
mtl: memory: Get memory windows configuration from DT
7892642
The sizes and locations of the memory windows are taken
from the device tree.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
abonislawski
abonislawski approved these changes Oct 18, 2022
View reviewed changes

@abonislawskiabonislawski left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge!

Green QB build on Internal CI

@kv2019i

kv2019i commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

Proceeding with merge. This uncovers some compiler warnings when built with Zephyr SDK, but this these were in existing code, so proceeding with merge. @softwarecki@abonislawski can you look at https://github.com/thesofproject/sof/actions/runs/3272915314/jobs/5384495135

@kv2019i
kv2019i merged commit 449b25a into thesofproject:mainOct 18, 2022
@kv2019i

kv2019i commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

This uncovers some compiler warnings when built with Zephyr SDK, but this these were in existing code, so proceeding with merge. @softwarecki@abonislawski can you look at https://github.com/thesofproject/sof/actions/runs/3272915314/jobs/5384495135

-> #6439

@aborisovichaborisovich mentioned this pull request Oct 18, 2022
Merged
9 tasks
This was referenced Oct 19, 2022
Merged
Merged
@softwarecki
softwarecki deleted the mtl branch March 4, 2024 15:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh approved these changes
@lgirdwoodlgirdwoodlgirdwood approved these changes
@abonislawskiabonislawskiabonislawski approved these changes
@kv2019ikv2019ikv2019i approved these changes
@marcinszkudlinskimarcinszkudlinskimarcinszkudlinski approved these changes
@marc-hbmarc-hbAwaiting requested review from marc-hb
@aborisovichaborisovichAwaiting requested review from aborisovich
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@softwarecki@lgirdwood@kv2019i@marc-hb@abonislawski@lyakh@marcinszkudlinski