Skip to content

ipc4: fix fw timeout in d0i3 test - #6478

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
RanderWang:ipc4_d0i3_fix
Nov 8, 2022
Merged

ipc4: fix fw timeout in d0i3 test#6478
kv2019i merged 1 commit into
thesofproject:mainfrom
RanderWang:ipc4_d0i3_fix

Conversation

@RanderWang

@RanderWangRanderWang commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

pm_runtime_disable | enable can't be called by ipc msg directly. According to ipc3 implementation,
pm_runtime_get | put are fit for d0i3 msg. Now
only primary core is supported and need to add
secondary core support in future.

Signed-off-by: Rander Wang rander.wang@intel.com

kv2019i
kv2019i reviewed Oct 25, 2022
View reviewed changes
Comment threadsrc/ipc/ipc4/handler.c Outdated

@kv2019ikv2019iOct 25, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially good, but I'll need a bit more time to review this. Is this @tmleman good for you and does not interfere with your PM enablement? We should really get away from calling the SOF pm_runtime_ interfaces, but this needs to be done incrementally.

@tmlemantmlemanOct 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will adapt to these changes.

ranj063
ranj063 reviewed Oct 25, 2022
View reviewed changes
Comment threadsrc/ipc/ipc4/handler.c Outdated
lyakh
lyakh reviewed Oct 26, 2022
View reviewed changes
Comment threadsrc/ipc/ipc4/handler.c Outdated
@tmleman

tmleman commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

@RanderWang this pull request will probably fix your issues with MTL.

@RanderWang
ipc4: fix fw panic in d0i3 test
124c080
pm_runtime_get | put can't be called by ipc
msg directly. According to ipc3 implementation,
pm_runtime_enable | disable are fit for d0i3 msg.
Signed-off-by: Rander Wang <rander.wang@intel.com>
lgirdwood
lgirdwood approved these changes Oct 27, 2022
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RanderWang can you check CI thanks.

@RanderWang

RanderWang commented Oct 28, 2022•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@RanderWang can you check CI thanks.

it depends on #6489 for MTL

@RanderWangRanderWang changed the title ipc4: fix fw panic in d0i3 testipc4: fix fw timeout in d0i3 testOct 28, 2022
@lgirdwood

lgirdwood commented Nov 2, 2022

Copy link
Copy Markdown
Member

CI was down, lets retry.

@lgirdwood

lgirdwood commented Nov 2, 2022

Copy link
Copy Markdown
Member

SOFCI TEST

@lgirdwood

lgirdwood commented Nov 7, 2022

Copy link
Copy Markdown
Member

@wszypelt@lrudyX seems we have a timeout with CI. Good to merge ?

@wszypelt

wszypelt commented Nov 8, 2022

Copy link
Copy Markdown

@lgirdwood good to merge

@tmleman

tmleman commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

@kv2019i I think this one is good to merge.

@kv2019i
kv2019i merged commit 14d173b into thesofproject:mainNov 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh left review comments
@ranj063ranj063ranj063 approved these changes
@lgirdwoodlgirdwoodlgirdwood approved these changes
@mmaka1mmaka1mmaka1 approved these changes
@abonislawskiabonislawskiabonislawski approved these changes
@kv2019ikv2019ikv2019i approved these changes
@marcinszkudlinskimarcinszkudlinskimarcinszkudlinski approved these changes
@tmlemantmlemantmleman approved these changes
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@aborisovichaborisovichAwaiting requested review from aborisovich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@RanderWang@tmleman@lgirdwood@wszypelt@lyakh@ranj063@mmaka1@abonislawski@kv2019i@marcinszkudlinski