ace: power policy management by tmleman · Pull Request #6489 · thesofproject/sof

tmleman · 2022-10-26T14:04:39Z

List of changes:

custom power policy: allows to override default power policy with application specific version,
default prevent for all lower power states,
add handlers to set/unset prevent on d0i3,
enabling zephyr power management function for MTL.

kv2019i

Looks good to go. One question @tmleman is what is the build error patch and why it's in this series? The build is fine in current main, and I don't see other changes in cpu.c in this PR. So what is failing?

lyakh · 2022-10-28T07:14:34Z

I'm not familiar with Zephyr PM API, are we safe here from put() or get() being unbalanced? I.e. can this function be called multiple times with the same value of enable?

Functions can be called multiple times but to balance the count of it is on the application side.

lgirdwood

@tmleman would be nice to have some more inline comments around the state logic i.e. explaining the policy and how we change state but that can be added later. Lets get this integrated and tested first.

lgirdwood · 2022-11-02T16:20:40Z

CI looks stuck. Retry.

lgirdwood · 2022-11-02T16:20:50Z

SOFCI TEST

lgirdwood · 2022-11-02T21:10:49Z

@tmleman like we have a build error on MTL in CI for GCC config.

This patch introduce custom power management policy for ace platforms. Default version depends mainly on system tick. Definition on the application side will allow later for better customization. When CONFIG_PM_POLICY_CUSTOM is set, kernel expect that application will provide custom policy implementation. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

This patch adds functions that allow to set/unset prevent on dynamic power gating. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

D3 (PM_STATE_SOFT_OFF) state can be only entered after IPC request from host. That why this prevent should be permanent. D0i3 (PM_STATE_RUNTIME_IDLE) can be entered if host allows it and under special conditions. State is prevented by default. Host will remove this prevent with dedicated IPC message. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

Adding missing header: rtos/wait.h The error appears in meteorlake after enabling power management. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

Enabling zephyr power management functionalities for meteorlake board. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

lgirdwood · 2022-11-03T11:55:11Z

@tmleman still seeing an error

/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c: In function 'up_down_mixer_new':
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:39: error: passing argument 2 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:77: note: expected 'struct comp_ipc_config *' but argument is of type 'const struct comp_ipc_config *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:47: error: passing argument 3 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:91: note: expected 'void *' but argument is of type 'const void *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~^~~~

kv2019i · 2022-11-03T12:03:47Z

@lgirdwood wrote:

@tmleman still seeing an error

/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c: In function 'up_down_mixer_new':
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:39: error: passing argument 2 of

That's caused by #6517 that was merged yesterday. My bad, should have caught this pre-merge. Let's address this in a separate PR.

UPDATE: fixed partly in #6529 , see comments about the hifi3/XCC dependency that remains

kv2019i · 2022-11-04T18:48:36Z

Known failures in CI. I did a local test with Zephyr SDK toolchain and all passes cleanly now. Proceeding with merge.

tmleman requested review from dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart as code owners October 26, 2022 14:04

tmleman requested review from abonislawski and marcinszkudlinski October 26, 2022 14:05

tmleman mentioned this pull request Oct 26, 2022
ipc4: fix fw timeout in d0i3 test #6478
Merged

tmleman force-pushed the topic/upstream/zephyr/pm/pm_policy branch from 41f81ec to eb80502Compare October 26, 2022 14:19

marcinszkudlinski approved these changes Oct 27, 2022
View reviewed changes

kv2019i reviewed Oct 27, 2022
View reviewed changes

Comment threadsrc/platform/intel/ace/lib/pm_runtime.c Outdated
Comment threadzephyr/wrapper.c Outdated
Comment threadsrc/lib-zephyr/cpu.c Outdated

lyakh reviewed Oct 28, 2022
View reviewed changes

tmleman force-pushed the topic/upstream/zephyr/pm/pm_policy branch from eb80502 to 0888514Compare November 1, 2022 00:05

tmleman requested review from kv2019i and lyakh November 1, 2022 00:20

lgirdwood approved these changes Nov 1, 2022
View reviewed changes

abonislawski approved these changes Nov 2, 2022
View reviewed changes

Comment threadzephyr/wrapper.c Outdated

tmleman force-pushed the topic/upstream/zephyr/pm/pm_policy branch from 0888514 to 0d208e7Compare November 2, 2022 09:01

tmleman added MTL Applies to Meteor Lake platform MTL-UPSTREAM Upstream local changes for MTL platform labels Nov 2, 2022

kv2019i approved these changes Nov 2, 2022
View reviewed changes

aborisovich mentioned this pull request Nov 2, 2022
soc: ace: fix IPC D3 power state entry #6440
Merged
9 tasks

aborisovich approved these changes Nov 2, 2022
View reviewed changes

tmleman force-pushed the topic/upstream/zephyr/pm/pm_policy branch from 0d208e7 to 87f7a4fCompare November 2, 2022 20:32

tmleman added 3 commits November 2, 2022 23:49

ace: power: handling d0i3 prevent
ddfe1b8
This patch adds functions that allow to set/unset prevent on dynamic power gating. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

tmleman added 2 commits November 2, 2022 23:49

ace: cpu: compilation error fix
1d90bf8
Adding missing header: rtos/wait.h The error appears in meteorlake after enabling power management. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

mtl: power: enabling zephyr power manager
aac1777
Enabling zephyr power management functionalities for meteorlake board. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>

tmleman force-pushed the topic/upstream/zephyr/pm/pm_policy branch from 87f7a4f to aac1777Compare November 2, 2022 22:50

kv2019i merged commit 7628908 into thesofproject:mainNov 4, 2022

tmleman deleted the topic/upstream/zephyr/pm/pm_policy branch May 23, 2024 11:18

Uh oh!

Conversation

tmleman commented Oct 26, 2022

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lyakhOct 28, 2022

Choose a reason for hiding this comment

Uh oh!

tmlemanOct 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgirdwood commented Nov 2, 2022

Uh oh!

lgirdwood commented Nov 2, 2022

Uh oh!

lgirdwood commented Nov 2, 2022

Uh oh!

lgirdwood commented Nov 3, 2022

Uh oh!

kv2019i commented Nov 3, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kv2019i commented Nov 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kv2019i commented Nov 3, 2022•
edited
Loading