Skip to content

hw hda chain managment - #6624

Closed
makarukp wants to merge 9 commits into
thesofproject:mainfrom
makarukp:prv-pmakaruk-hw_hda_chain_managment_mtl-002-drop-stable
Closed

hw hda chain managment#6624
makarukp wants to merge 9 commits into
thesofproject:mainfrom
makarukp:prv-pmakaruk-hw_hda_chain_managment_mtl-002-drop-stable

Conversation

@makarukp

@makarukpmakarukp commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

This is only temporary draft PR (work in progress)

softwareckiand others added 9 commits November 2, 2022 19:57
@softwarecki@abonislawski
dmic workaround
d725d3b
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Arsen Eloglian@abonislawski
mtl: enable comp up down mixer
fb63108
Enable flag configures up down mixer.
Signed-off-by: Arsen Eloglian <ArsenX.Eloglian@intel.com>
@fkwasowi@abonislawski
src:change error to warning when checking buffer
4fd043d
PR to change the error into a warning
is a good quick compromise
until a better limit is figured out
Signed-off-by: Kwasowiec, Fabiola <fabiola.kwasowiec@intel.com>
@kv2019i@abonislawski
audio: up_down_mixer: fix build warnings on discarding const
0714872
Fix compiler warnings on discarding const when passing
arguments to init_up_down_mixer [-Werror=discarded-qualifiers].
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@abonislawski
west: update to newer Zephyr baseline
9fbcce1
Update Zephyr co commit a27ac688779b from mtl-002-drop-stable branch
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@ranj063@abonislawski
lib: dma: free dma channels when ref count is 0
c24359a
Free the memory allocated for DMA channels when the ref count is 0 when
using native zephyr drivers.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063@abonislawski
lib: dma: return NULL when DMA init fails
071f46c
Return NULL when dma_init() fails.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063@abonislawski
dai-zephyr: Free DMA config block during reset
3216d45
This prevents memory leaks during repeated PCM start/stop tests.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@makarukp
hda: Add chain dma management
79289e0
remove sw support for hda chain
add hw chain dma support
Signed-off-by: Piotr Makaruk <piotr.makaruk@intel.com>
plbossart
plbossart reviewed Nov 17, 2022
View reviewed changes
Comment threadsrc/include/ipc/topology.h
lgirdwood
lgirdwood reviewed Nov 18, 2022
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup of debug, code style and indentation is needed. I would split out the west update into a separate PR so this can be separately tested by validation prior to merge.

Comment threadsrc/include/ipc/topology.h
Comment threadsrc/ipc/ipc4/handler.c
Comment threadsrc/ipc/ipc4/handler.c
Comment threadsrc/ipc/ipc4/handler.c
Comment threadsrc/ipc/ipc4/handler.c
Comment threadsrc/ipc/ipc4/handler.c
Comment threadsrc/ipc/ipc4/helper.c
Comment threadsrc/ipc/ipc4/helper.c
Comment threadsrc/ipc/ipc4/helper.c
Comment threadsrc/ipc/ipc4/helper.c
@makarukp

makarukp commented Nov 18, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This is only draft PR under debug. Solution is not completed.
Please do not test it yet!

@makarukp

makarukp commented Nov 23, 2022•
edited by paulstelian97
Loading

Copy link
Copy Markdown
ContributorAuthor

I have to close that PR. Continuation of issue:
image ( #6656 )

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsarhajsarhajsarha left review comments
@plbossartplbossartplbossart left review comments
@lgirdwoodlgirdwoodlgirdwood left review comments
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i will be requested when the pull request is marked ready for reviewkv2019i is a code owner
@lyakhlyakhAwaiting requested review from lyakhlyakh will be requested when the pull request is marked ready for reviewlyakh is a code owner
@iuliana-prodaniuliana-prodanAwaiting requested review from iuliana-prodaniuliana-prodan will be requested when the pull request is marked ready for reviewiuliana-prodan is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta will be requested when the pull request is marked ready for reviewdbaluta is a code owner
@abonislawskiabonislawskiAwaiting requested review from abonislawskiabonislawski will be requested when the pull request is marked ready for reviewabonislawski is a code owner
@singalsusingalsuAwaiting requested review from singalsusingalsu will be requested when the pull request is marked ready for reviewsingalsu is a code owner
@tmlemantmlemanAwaiting requested review from tmlemantmleman will be requested when the pull request is marked ready for reviewtmleman is a code owner
@pblaszkopblaszkoAwaiting requested review from pblaszkopblaszko will be requested when the pull request is marked ready for reviewpblaszko is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 will be requested when the pull request is marked ready for reviewmmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej will be requested when the pull request is marked ready for reviewlbetlej is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@makarukp@jsarha@plbossart@lgirdwood@softwarecki@fkwasowi@kv2019i@abonislawski@ranj063