Add more robust method to retrieve config JSON from the terminal by stereokai · Pull Request #16 · timolins/hyperlayout

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

stereokai · 2016-12-14T13:10:46Z

@timolins
This fixes Hyperlayout simply printing out config for me and gets Hyperlayout to work on Windows. 😄

timolins

great job! Will test this out as soon as I can.

timolins · 2016-12-14T13:12:57Z

 const {sessions} = store.getState()
 const {activeUid} = sessions
+ // Remove ANSI escape code sequences. Visualization: https://goo.gl/IY8vuU
+ const ANSI_escape_codes = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/gm


These constants won't change, so they shouldn't be defined inside the middleware.

That's true. I'll update.

timolins · 2016-12-14T13:24:34Z

Awesome! Would be cool if you changed the variables from snake_case to camelCase to obey the linter. 🐫

timolins · 2016-12-14T13:29:01Z

Thanks 🙏

stereokai · 2016-12-14T13:37:48Z

Green light

timolins · 2016-12-14T21:25:03Z

This might sound weird, but your pull request basically killed my Hyper.app. 😅

stereokai · 2016-12-15T07:12:09Z

:(

Maybe try to disable one or more of the regexes I introduced to discover the culprit?

stereokai · 2016-12-15T08:42:31Z

@timolins I had the same problem with PowerShell in my machine. (I tried with 3 different shells, including cmd and native Bash). The problem with PowerShell was that it was printing a security error to the terminal immediately after it was loaded - and it threw hyperlayout into a loop or a freeze somehow. Just to be more clear - that error text was being printed to the terminal before PowerShell's command prompt was visible and ready to receive commands.

That error was not related to Hyper, and would happen even if I opened PowerShell independently. The moment I fixed the error, (read: removed the content that was being printed before the command prompt was available in the terminal) the freeze was gone.

Does your terminal print some things before the command prompt is ready for input?

stereokai · 2016-12-19T17:59:44Z

@timolins still there? :)

timolins · 2016-12-19T18:00:57Z

Awesome, thank you! Don't know how I missed this... Will check this out soon!

Edit: Oh wait, I mixed something up here. For some reason I thought you fixed that issue.

timolins · 2016-12-21T20:40:41Z

And no, my command prompt doesn't print anything before it's ready for input.

stereokai · 2016-12-21T21:24:56Z

@timolins Did you try to disable one or more of the regexes I introduced to discover the culprit like I suggested? :)

colinbate · 2017-05-10T18:00:09Z

This code killed my Hyper too. It is the configMatcher which does it.

I've been wrestling with getting hyperlayout to work at all on Windows 7. The addition of the ANSI codes and line breaks isn't a simple one to solve. For example, my config was broken onto three lines, the first line break being inserted instead of a space within a command string. The second was inserted mid-string. If I replace the newlines with an empty string, I break that first command.

colinbate · 2017-05-10T18:45:55Z

If I change the size of my Hyper window, then the line breaks go elsewhere and can be removed more safely. Is this really the best way to communicate between the command and the plugin?

timolins · 2017-05-10T19:44:46Z

I'm open for suggestions. While developing hyperlayout, I tried a few different approaches, but the current implementation was the best one I came up with. Of course this doesn't mean that there isn't a better one. Feel free to come up with a new solution! 🙂

colinbate · 2017-05-10T20:37:20Z

Fair enough. At the moment I feel frustrated by the lack of documentation around the Hyper APIs. :) I don't think the issue is with hyperlayout per se.

Would it be possible for the plugin to do some of the work the command does? Reading the config files?

iamstarkov · 2017-06-14T11:57:12Z

this fix seems to solve problems on windows

philoserf · 2018-01-06T06:28:11Z

I see the project has drifted from the pull request.

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Add more robust method to retrieve config JSON from the terminal
e6dabbd

timolins reviewed Dec 14, 2016
View reviewed changes

Move constants to module scope
d1000fa

Convert identifiers to camel case
cf0466b

Fix the rest of the linter errors
f0f8dd9

stereokai mentioned this pull request Dec 19, 2016
Hyperlayout simply printing out config #8
Open

Conversation

stereokai commented Dec 14, 2016

Uh oh!

timolins left a comment

Choose a reason for hiding this comment

Uh oh!

timolinsDec 14, 2016

Choose a reason for hiding this comment

Uh oh!

stereokaiDec 14, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stereokaiDec 14, 2016

Choose a reason for hiding this comment

Uh oh!

timolins commented Dec 14, 2016

Uh oh!

timolins commented Dec 14, 2016

Uh oh!

stereokai commented Dec 14, 2016

Uh oh!

timolins commented Dec 14, 2016

Uh oh!

stereokai commented Dec 15, 2016

Uh oh!

stereokai commented Dec 15, 2016

Uh oh!

stereokai commented Dec 19, 2016

Uh oh!

timolins commented Dec 19, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timolins commented Dec 21, 2016

Uh oh!

stereokai commented Dec 21, 2016

Uh oh!

colinbate commented May 10, 2017

Uh oh!

colinbate commented May 10, 2017

Uh oh!

timolins commented May 10, 2017

Uh oh!

colinbate commented May 10, 2017

Uh oh!

iamstarkov commented Jun 14, 2017

Uh oh!

philoserf commented Jan 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

stereokai commented Dec 14, 2016

Uh oh!

timolins left a comment

Choose a reason for hiding this comment

Uh oh!

timolinsDec 14, 2016

Choose a reason for hiding this comment

Uh oh!

stereokaiDec 14, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stereokaiDec 14, 2016

Choose a reason for hiding this comment

Uh oh!

timolins commented Dec 14, 2016

Uh oh!

timolins commented Dec 14, 2016

Uh oh!

stereokai commented Dec 14, 2016

Uh oh!

timolins commented Dec 14, 2016

stereokaiDec 14, 2016•
edited
Loading

timolins commented Dec 19, 2016•
edited
Loading

stereokaiDec 14, 2016•
edited
Loading

timolins commented Dec 19, 2016•
edited
Loading

stereokaiDec 14, 2016•
edited
Loading