Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
---
doc-type: issue
issue-type: task
status: open
status: done
priority: p2
epic: 2003
github-issue: 2233
spec-path: docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
spec-path: docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
branch: "2233-2003-tune-unified-pr-review-process"
related-pr: 2237
last-updated-utc: 2026-09-16 15:10
last-updated-utc: 2026-09-16 16:33
semantic-links:
skill-links:
- create-issue
- process-pr-review
related-artifacts:
- docs/issues/open/2233-2003-tune-unified-pr-review-process/agent-review-reports.md
- docs/issues/open/2003-overhaul-guardrails-and-automation/EPIC.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/agent-review-reports.md
- docs/issues/closed/2219-2003-unify-pr-review-processing/ISSUE.md
- docs/pr-reviews/pr-2232-review.md
- docs/templates/REVIEW-FINDINGS.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
- docs/issues/open/2233-2003-tune-unified-pr-review-process/implementation-retrospective.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/manual-verification-evidence.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/tiered-model-routing-design.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/implementation-retrospective.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/manual-verification-evidence.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/tiered-model-routing-design.md
- docs/issues/drafts/refactor-semantic-link-conventions/EPIC.md
- .github/skills/dev/planning/create-issue/SKILL.md
- .github/skills/dev/pr-reviews/process-pr-review/SKILL.md
Expand Down Expand Up @@ -122,7 +122,7 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
Candidate T4 verification contract:

```sh
actual_patch=$(git diff -U0 "<base>:<old-path>" "<new-path>")
actual_patch=$(git diff -U0 "<base>:<old-path>" "HEAD:<new-path>")
test "$actual_patch" = "$(cat "<approved-zero-context-patch>")"
```

Expand All @@ -147,7 +147,7 @@ commit with GPG and use a Conventional Commit subject with the narrow affected s

### Workflow Checkpoints

- [x] Folder-style spec drafted in `docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md`
- [x] Folder-style spec archived in `docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md`
- [x] GitHub issue created and issue number added to this spec
- [x] Spec reviewed and approved by user/maintainer
- [x] Spec-only PR merged into `develop` before implementation
Expand All @@ -159,7 +159,7 @@ commit with GPG and use a Conventional Commit subject with the narrow affected s
- [x] Reviewer validated acceptance criteria and updated checkboxes
- [x] Independent reviewer reports recorded in issue-local `agent-review-reports.md` when reviewers received this folder-style specification
- [x] Committer verified spec progress is up to date before commit
- [ ] Issue closed and spec moved from `docs/issues/open/` to `docs/issues/closed/`
- [x] Issue closed and spec moved from `docs/issues/open/` to `docs/issues/closed/`

### Progress Log

Expand Down Expand Up @@ -189,6 +189,9 @@ commit with GPG and use a Conventional Commit subject with the narrow affected s
the issue progress record is ready for the completion evidence commit.
- 2026-09-16 15:10 UTC - Copilot - Opened implementation PR #2237 targeting `develop` with
`Closes #2233`; PR #2235 remains the spec-only merge evidence.
- 2026-09-16 16:33 UTC - Copilot - PR #2237 merged into `develop` as signed merge commit
`678aa310ab5da21cf7e63754514692f689f0e2af`; GitHub issue #2233 closed automatically and this
spec was archived under `docs/issues/closed/`.

## Acceptance Criteria

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
semantic-links:
related-artifacts:
- .github/agents/task-reviewer.agent.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
---

# Agent Review Reports - Issue #2233
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ add a checker beyond Lychee, and if so which cases should be strict, ignored by
with explicit review evidence.

The complete case list is in
`docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv`.
`docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv`.

## Scan Scope

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ semantic-links:
skill-links:
- process-pr-review
related-artifacts:
- docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
- docs/issues/drafts/refactor-semantic-link-conventions/EPIC.md
---

Expand Down Expand Up @@ -63,8 +63,8 @@ to become a semantic link.

## Evidence

- `docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md`
- `docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md`
- `docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv`
- `docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md`
- `docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md`
- `docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv`
- `docs/issues/drafts/refactor-semantic-link-conventions/EPIC.md`
- `docs/issues/open/2233-2003-tune-unified-pr-review-process/tiered-model-routing-design.md`
- `docs/issues/closed/2233-2003-tune-unified-pr-review-process/tiered-model-routing-design.md`
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
doc-type: manual-verification-evidence
issue-spec: docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
issue-spec: docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
last-updated-utc: 2026-09-16 14:54
---

Expand Down
8 changes: 4 additions & 4 deletions docs/issues/drafts/refactor-semantic-link-conventions/EPIC.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ status: draft
github-issue: null
spec-path: docs/issues/drafts/refactor-semantic-link-conventions/EPIC.md
epic-owner: null
last-updated-utc: 2026-09-16 13:17
last-updated-utc: 2026-09-16 16:33
semantic-links:
skill-links:
- create-issue
related-artifacts:
- docs/skills/semantic-skill-link-convention.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/open/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-analysis.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/code-span-path-case-inventory.tsv
---

# EPIC #[To be assigned] - Refactor Semantic Link and Frontmatter Conventions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ status: planned
github-issue: 2003
spec-path: docs/issues/open/2003-overhaul-guardrails-and-automation/EPIC.md
epic-owner: josecelano
last-updated-utc: 2026-09-16 11:09
last-updated-utc: 2026-09-16 16:33
semantic-links:
skill-links:
- create-issue
Expand All @@ -27,6 +27,7 @@ semantic-links:
- docs/issues/open/1768-refactor-update-dependencies-skill-automation/ISSUE.md
- docs/issues/open/2003-overhaul-guardrails-and-automation/initial-inventory.md
- docs/issues/open/2003-overhaul-guardrails-and-automation/previous-single-runner-proposal.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
---

<!-- skill-link: create-issue -->
Expand Down Expand Up @@ -246,6 +247,7 @@ creation remains subject to maintainer approval of each draft specification.
| 6 | #2160 - Persist independent agent review reports | `docs/issues/closed/2160-2003-persist-independent-agent-review-reports/ISSUE.md` | Profile/template documentation and explicit records; does not enforce transitions technically. | #2155 documentation conventions, if merged first |
| 7 | #2185 - Triage advisory external-link check findings | `docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/ISSUE.md` | Evidence-driven refinement of an existing advisory workflow; does not redesign the linter or workflow runner. | #2162 external-link workflow |
| 8 | #2219 - Unify PR review-processing workflow (DONE) | `docs/issues/closed/2219-2003-unify-pr-review-processing/ISSUE.md` | Low-risk, additive, independently verifiable local/CI formatting parity plus skill, template, and review-audit process improvements; selects no shared automation architecture. | Existing pre-commit, pre-push, and PR-review entry points |
| 9 | #2233 - Tune unified PR-review process (DONE) | `docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md` | Evidence-driven follow-up to #2219; refines skills, templates, audit process, and design notes without selecting shared automation architecture. | #2219 PR-review workflow evidence |

## Delivery Strategy

Expand Down
2 changes: 1 addition & 1 deletion docs/pr-reviews/pr-2237-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ semantic-links:
skill-links:
- process-pr-review
related-artifacts:
- docs/issues/open/2233-2003-tune-unified-pr-review-process/ISSUE.md
- docs/issues/closed/2233-2003-tune-unified-pr-review-process/ISSUE.md
- .github/skills/dev/pr-reviews/process-pr-review/SKILL.md
---

Expand Down
Loading