Uh oh!
There was an error while loading. Please reload this page.
Remove third-party contributions and plug the gaps - #353
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
socksy
left a comment
There was a problem hiding this comment.
kinda hard to review in one go, but it all looks ok... I haven't tried it out though, putting some faith into those newly rewritten BDD tests (might be a good idea to run them against the real backend too?)
This pull requests reverts third-party commits that aren't covered by our CLA and patches the holes left behind in the CLI. We have a separate process that we've introduced for tracking CLA signing going forward, we just can't reasonably do the CLA signing retroactively given the age of the commits.
Why?
We ship
tower/tower-cliunder an MIT license and we have to show that every line we ship is actually ours to license. One contributor's commits carried an employment question we couldn't resolve in time, so leaving the code in place would have meant shipping something a third party might have a claim on, which is a risk that compounds with every release and every downstream user.Reverting the code and rebuilding it from a functional spec, with the record to prove the separation, remediates the issue.