Skip to content

Remove third-party contributions and plug the gaps - #353

Merged
bradhe merged 13 commits into
developfrom
rework-logs-follow-schedules-dbt
Aug 14, 2026
Merged

Remove third-party contributions and plug the gaps#353
bradhe merged 13 commits into
developfrom
rework-logs-follow-schedules-dbt

Conversation

@bradhe

Copy link
Copy Markdown
Contributor

This pull requests reverts third-party commits that aren't covered by our CLA and patches the holes left behind in the CLI. We have a separate process that we've introduced for tracking CLA signing going forward, we just can't reasonably do the CLA signing retroactively given the age of the commits.

Why?

We ship tower/tower-cli under an MIT license and we have to show that every line we ship is actually ours to license. One contributor's commits carried an employment question we couldn't resolve in time, so leaving the code in place would have meant shipping something a third party might have a claim on, which is a risk that compounds with every release and every downstream user.

Reverting the code and rebuilding it from a functional spec, with the record to prove the separation, remediates the issue.

@bradhe
bradhe requested a review from socksyAugust 14, 2026 10:23
@coderabbitai

coderabbitaiBot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8d3cc69-79df-458d-a459-907935f42a35

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@bradhebradhe changed the title Rework logs follow schedules dbtRemove third-party contributions and plug the gapsAug 14, 2026

@socksysocksy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda hard to review in one go, but it all looks ok... I haven't tried it out though, putting some faith into those newly rewritten BDD tests (might be a good idea to run them against the real backend too?)

@bradhe
bradhe merged commit a862fcb into developAug 14, 2026
29 checks passed
@bradhe
bradhe deleted the rework-logs-follow-schedules-dbt branch August 14, 2026 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bradhe@socksy