Uh oh!
There was an error while loading. Please reload this page.
fix(closure-router): issue closed-as-completed mirrors closing PR's resulting Status - #33
Merged
Merged
Conversation
Caught by Asad. When a PR closes a linked issue (via 'Closes #N') and the PR is still in Functional review (merged to develop, awaiting prod), the issue was being routed independently to Done — splitting the pair. Fix: on issue closed-as-completed, look up the closing PR via timeline and mirror its resulting Status (Functional review for develop/staging, Done for main/master, Done as default for manually-closed issues with no linked PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug caught by Asad — issue linked to PR #114 was sent to Done while PR sat in Functional review. Now syncs by looking up the closing PR's base branch.