Uh oh!
There was an error while loading. Please reload this page.
promote: develop caveat in the PR template (develop -> main) - #114
Merged
Conversation
client and cli both carry this caveat in their own PR templates, and it is not repo-specific -- every repo targets develop, and GitHub only honours closing keywords when a PR merges into the DEFAULT branch. So `Closes#123` on a develop-targeted PR silently does nothing until the change reaches main/master. Lifting it into the org template is a precondition for backend#1373: the plan there is to delete the per-repo templates so the org one applies, and this is one of the two things those templates knew that the shared one did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
docs: note that closing keywords do not fire on a develop merge
LukasWodka
commented
Jul 31, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 41 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #113 — the note that closing keywords do not fire on a develop merge.
Ordering matters here: backend#1373 deletes the per-repo PR templates so repos inherit this one, and repos inherit the copy on main. Both template improvements (#111 expand-then-contract, #113 the develop caveat) need to be on main before those deletions land, or the nine repos would inherit a template missing exactly the two things their own templates knew.
Docs-only, already reviewed and Bugbot-clean on #113.
Note
Low Risk
Comment-only change to the PR template with no runtime or security impact.
Overview
Updates the Related section guidance in the org-wide
.github/pull_request_template.mdso authors know that closing keywords do not auto-close issues when PRs merge intodevelopinstead of the default branch—they should confirm the linked issue actually closed.Docs-only promotion of the same note from #113, timed so
mainhas this text before per-repo templates are removed and repos inherit this file.Reviewed by Cursor Bugbot for commit 480a8f4. Bugbot is set up for automated code reviews on this repo. Configure here.