Skip to content

promote: develop caveat in the PR template (develop -> main) - #114

Merged
LukasWodka merged 2 commits into
mainfrom
develop
Jul 31, 2026
Merged

promote: develop caveat in the PR template (develop -> main)#114
LukasWodka merged 2 commits into
mainfrom
develop

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Promotes #113 — the note that closing keywords do not fire on a develop merge.

Ordering matters here: backend#1373 deletes the per-repo PR templates so repos inherit this one, and repos inherit the copy on main. Both template improvements (#111 expand-then-contract, #113 the develop caveat) need to be on main before those deletions land, or the nine repos would inherit a template missing exactly the two things their own templates knew.

Docs-only, already reviewed and Bugbot-clean on #113.


Note

Low Risk
Comment-only change to the PR template with no runtime or security impact.

Overview
Updates the Related section guidance in the org-wide .github/pull_request_template.md so authors know that closing keywords do not auto-close issues when PRs merge into develop instead of the default branch—they should confirm the linked issue actually closed.

Docs-only promotion of the same note from #113, timed so main has this text before per-repo templates are removed and repos inherit this file.

Reviewed by Cursor Bugbot for commit 480a8f4. Bugbot is set up for automated code reviews on this repo. Configure here.

LukasWodkaand others added 2 commits July 31, 2026 09:09
client and cli both carry this caveat in their own PR templates, and it is not
repo-specific -- every repo targets develop, and GitHub only honours closing
keywords when a PR merges into the DEFAULT branch. So `Closes#123` on a
develop-targeted PR silently does nothing until the change reaches main/master.
Lifting it into the org template is a precondition for backend#1373: the plan
there is to delete the per-repo templates so the org one applies, and this is
one of the two things those templates knew that the shared one did not.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
docs: note that closing keywords do not fire on a develop merge
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 41 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@LukasWodka
LukasWodka merged commit fbd4b24 into mainJul 31, 2026
6 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@LukasWodka