Skip to content

fix(wip-limit-check): drop permissions block — caused startup_failure - #37

Merged
saadqbal merged 1 commit into
developfrom
fix/wip-limit-check-drop-permissions-block
May 4, 2026
Merged

fix(wip-limit-check): drop permissions block — caused startup_failure#37
saadqbal merged 1 commit into
developfrom
fix/wip-limit-check-drop-permissions-block

Conversation

@saadqbal

@saadqbalsaadqbal commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

The reusable workflow declared permissions: pull-requests: write on its job. Callers (e.g. `tracebloc-py-package`) don't grant that, and GitHub forbids called workflows from elevating `GITHUB_TOKEN` scope, so the workflow short-circuits to `startup_failure` before any step runs.

The block is also unnecessary: this workflow doesn't use `GITHUB_TOKEN` at all — `gh pr comment` runs under `secrets.PROJECTS_KANBAN_TOKEN` (a PAT). Removing it restores startup parity with the other reusable workflows in this repo (`set-pr-status`, `add-to-kanban`, `auto-classify`, `kanban-closure-router`), none of which declare a permissions block.

Reproducer

tracebloc/tracebloc-py-package#117 → run 25170342114conclusion: startup_failure, 0 jobs spawned.

Test plan

🤖 Generated with Claude Code


Note

Low Risk
Low risk: removes an unnecessary permissions block that was preventing the reusable workflow from starting when callers don’t grant elevated GITHUB_TOKEN scopes.

Overview
Fixes the reusable wip-limit-check workflow failing with startup_failure by removing the job-level permissions: pull-requests: write declaration.

This ensures the workflow runs under the existing PAT (secrets.PROJECTS_KANBAN_TOKEN) without attempting to elevate GITHUB_TOKEN permissions in called workflows.

Reviewed by Cursor Bugbot for commit bf7980d. Bugbot is set up for automated code reviews on this repo. Configure here.

@saadqbal
saadqbalforce-pushed the fix/wip-limit-check-drop-permissions-block branch from 6e53b85 to 38cb399CompareMay 4, 2026 13:18
The reusable workflow declared `permissions: pull-requests: write` on
its job. Callers (e.g. tracebloc-py-package) don't grant that, and
GitHub forbids called workflows from elevating GITHUB_TOKEN scope, so
the workflow short-circuited to `startup_failure` before any step ran.
The block is also unnecessary: this workflow doesn't use GITHUB_TOKEN
at all — `gh pr comment` runs under `secrets.PROJECTS_KANBAN_TOKEN`
(a PAT). Removing the block restores startup parity with the other
reusable workflows in this repo, none of which declare a permissions
block.
Verified locally that py-package PR #117 hit startup_failure with the
old YAML; all sibling reusables (set-pr-status, add-to-kanban, etc.)
have no permissions block and run fine.
@saadqbal
saadqbalforce-pushed the fix/wip-limit-check-drop-permissions-block branch from 38cb399 to bf7980dCompareMay 4, 2026 13:22
@saadqbal
saadqbal merged commit c87b686 into developMay 4, 2026
1 check passed
@LukasWodkaLukasWodka added bug Something isn't working work-type:bug Defect or regression labels Jun 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingwork-type:bugDefect or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@saadqbal@LukasWodka