Uh oh!
There was an error while loading. Please reload this page.
feat(data ingest): destination-table guard (--overwrite) + honest extension handling - #145
Merged
saadqbal merged 1 commit intoJul 7, 2026
Conversation
…ension handling
Two fixes for the same failure class — the customer uploads their whole
dataset and only then learns it was doomed:
cli#70 (P4-lite) — table-exists guard:
- One cheap read (the data list query) after cluster discovery, BEFORE
staging. Existing table without --overwrite → exit 6 (new, documented)
with the full remedy; --overwrite replaces it via the exact teardown
data delete uses. The check fails OPEN with a visible note (the
in-cluster duplicate check still backstops).
- Teardown acts on the MATCHED name, not the flag's casing (Linux MySQL
+ PVC paths are case-sensitive; acting on the flag spelling could
silently no-op the DROP/rm and claim success).
- --overwrite + --idempotency-key is refused outright: a replayed
submit attaches to the PREVIOUS run after the teardown deleted the
data — false success + data loss. (Adversarial-review catch.)
- Honest partial-failure copy: a half-finished replace names
`data delete` as the primary recovery — a plain re-run would pass
the DB-backed guard and hit the leftover files after a full upload.
- The teardown pod honors --stage-pod-image (air-gapped registries).
cli#68 — extension detection/emission:
- .webp removed from the accept-set: the ingestor's FileExtension enum
+ the ingest.v1 schema allow only .jpg/.jpeg/.png for images, and
FileTypeValidator RAISES on webp — accepting it locally guaranteed an
in-cluster failure after the full upload. (The old comment claiming
chart support was itself the cli#68 drift.)
- The single shared extension is detected, shown in the summary
("3 files (.png)"), and emitted as spec.file_options.extension so
the cluster validates the type that was actually staged — previously
it checked its .jpeg convention default and rejected .jpg/.png
datasets after upload.
- Mixed types fail locally with counts (exit 3); an all-unsupported
dataset names what was found vs accepted.
Cross-repo traced against data-ingestors (conventions merge, per-
category validator factories, DuplicateValidator) and live-verified on
a real cluster: PNG detection, guard on an existing table (exit 6),
--overwrite dry-run creates nothing, mixed extensions refused, combo
flag refusal. go build/vet/test green; new tests cover the guard seam
(matched-name contract, fail-open), extension detection, spec emission
+ schema validation (keypoint top-level fields pinned), and the summary
rendering.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>LukasWodka
commented
Jul 7, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 32 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jul 7, 2026
saadqbal
approved these changes
Jul 7, 2026
saadqbal
merged commit Jul 7, 2026
090be58
into
ux/cli-surface-and-namespace-discovery
5 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 7, 2026
This was referenced Jul 7, 2026
saadqbal added a commit
that referenced
this pull request
Jul 7, 2026
…n handling (#149) * feat(data ingest): destination-table guard (--overwrite) + honest extension handling (#145) Two fixes for the same failure class — the customer uploads their whole dataset and only then learns it was doomed: cli#70 (P4-lite) — table-exists guard: - One cheap read (the data list query) after cluster discovery, BEFORE staging. Existing table without --overwrite → exit 6 (new, documented) with the full remedy; --overwrite replaces it via the exact teardown data delete uses. The check fails OPEN with a visible note (the in-cluster duplicate check still backstops). - Teardown acts on the MATCHED name, not the flag's casing (Linux MySQL + PVC paths are case-sensitive; acting on the flag spelling could silently no-op the DROP/rm and claim success). - --overwrite + --idempotency-key is refused outright: a replayed submit attaches to the PREVIOUS run after the teardown deleted the data — false success + data loss. (Adversarial-review catch.) - Honest partial-failure copy: a half-finished replace names `data delete` as the primary recovery — a plain re-run would pass the DB-backed guard and hit the leftover files after a full upload. - The teardown pod honors --stage-pod-image (air-gapped registries). cli#68 — extension detection/emission: - .webp removed from the accept-set: the ingestor's FileExtension enum + the ingest.v1 schema allow only .jpg/.jpeg/.png for images, and FileTypeValidator RAISES on webp — accepting it locally guaranteed an in-cluster failure after the full upload. (The old comment claiming chart support was itself the cli#68 drift.) - The single shared extension is detected, shown in the summary ("3 files (.png)"), and emitted as spec.file_options.extension so the cluster validates the type that was actually staged — previously it checked its .jpeg convention default and rejected .jpg/.png datasets after upload. - Mixed types fail locally with counts (exit 3); an all-unsupported dataset names what was found vs accepted. Cross-repo traced against data-ingestors (conventions merge, per- category validator factories, DuplicateValidator) and live-verified on a real cluster: PNG detection, guard on an existing table (exit 6), --overwrite dry-run creates nothing, mixed extensions refused, combo flag refusal. go build/vet/test green; new tests cover the guard seam (matched-name contract, fail-open), extension detection, spec emission + schema validation (keypoint top-level fields pinned), and the summary rendering. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(data ingest): preflight parity — the dry-run's promise becomes a checked contract (#150) * feat(data ingest): preflight parity — the dry-run's promise becomes a checked contract backend#828 P3; closes cli#69, cli#71, cli#72, cli#73. Every local check now previews a NAMED data-ingestors validator with matching semantics, so 'preflight passed' means the in-cluster validation passes too — failures land BEFORE the upload, not after. New previews (internal/push/preflight.go, each cites its source rule): - label column exists (LabelColumnValidator: exact, then case-insensitive+trimmed — never stricter than the cluster) (#69) - BOM: tabular rejected pre-upload (the in-cluster stdlib schema probe falsely rejects BOM'd CSVs — data-ingestors#338); image/text BOM accepted+stripped, matching the pandas paths (#71) - every image decoded (header-only, cheap): zero-byte, corrupt, resolution vs target — plus the labels↔images cross-check with the ingestor's _has_extension naming semantics (dotted stems!) (#72) - duplicate headers (stripped, case-SENSITIVE like the probe), zero data rows, --schema columns ⊆ header, CSV encoding gate (check_csv_encoding preview: UTF-8 + no NUL) (#73 + gaps found) - label diversity (LabelDiversityValidator: >=2 classes; NA-sentinel drop + numeric collapse for schema-typed tabular labels; empty string IS a class for image/text) — discovered BY the harness's first run, was in no ticket - object_detection images↔annotations stem pairing (FilePairingValidator preview) FIXES A PRE-EXISTING SHIP-BLOCKER found by the adversarial pass: spec.go swapped target_size to [H,W] on emit (mistaken review note) — but the schema + ImageResolutionValidator compare PIL's (W,H) verbatim, so EVERY non-square dataset failed in-cluster post-upload. Emission is now [W,H]; the parity pair imgc-nonsquare / imgc-nonsquare-swapped pins the orientation end-to-end against the real validator. THE PARITY HARNESS (the durable part): - internal/push/testdata/parity: 23 fixture cases + goldens.json GENERATED from the real Python validators (scripts/gen-validator-goldens.py; scripts/sync-validator-goldens.sh --check for drift, verdict-level) - parity_golden_test.go asserts the PRODUCTION dispatch (push.PreflightDataset — shared by runDataIngest and the test, so the two cannot drift) reaches the manifest's verdict per case, and that committed goldens match the manifest — an ingestor rule change fails the test until consciously reconciled - deliberate divergences (read-/transfer-time failures the ingestor's preflight can't see but the CLI previews) are explicit manifest notes, never silent Verified: 23/23 parity green; full go test green; live dry-runs on a real cluster (missing file, bad label column, single-class, latin-1, non-square 320x200 accept). Adversarial review (2 lenses, high effort): all findings folded incl. the [W,H] bug, value-semantics divergences in diversity/cross-check, the encoding gate, de-masked fixtures, the shared dispatch, and a vacuous kubeconfig test revived with decodable fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(preflight): label diversity respects the label's SQL type (#152) CheckLabelDiversity collapsed numeric-looking labels ("1"/"1.0") for every tabular_classification dataset. The in-cluster LabelDiversityValidator pins dtype=str for string-family schema types (VARCHAR/CHAR/TEXT/STRING), so those labels stay distinct — only numeric types get pandas numeric inference (data-ingestors #252). A user-declared VARCHAR label with numeric-looking classes was wrongly rejected at preflight. Derive the drop-NA and collapse-numeric flags from the label's declared schema type at the dispatch site; keep image/text (untyped) unchanged. Adds leaf + dispatch tests. This aligns the Go side with the golden generator, which already types columns as VARCHAR. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Asad Iqbal (Saadi) <asad.dsoft@gmail.com> * fix(preflight): check deferred file Close (errcheck) preflight.go used bare `defer f.Close()`, which the required Lint job's `errcheck ./...` rejects on develop. Match the repo convention used in detect.go / tabular.go / stream.go: `defer func() { _ = f.Close() }()`. These are read-only opens for validation, so dropping the close error is intentional. Slipped through earlier because the stacked merges never hit the full Lint-on-develop gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Asad Iqbal (Saadi) <asad.dsoft@gmail.com>
saadqbal added a commit
that referenced
this pull request
Jul 7, 2026
…] emit (#153) The TargetSize field NOTE still described the old #25/[H,W] behavior ("EMITTED as [height, width] ... buildImage does the swap"), which #147 (landed via #149) deliberately reverted. buildImage now emits [TargetSize[0], TargetSize[1]] = [width, height] with no swap — the order ingest.v1.json documents ("matches PIL.Image.size and what ImageResolutionValidator expects") and the order image_validator.py compares against verbatim. Rewrite the NOTE to state stored-and-emitted [width, height], no swap, and warn against re-introducing the swap (which failed every non-square dataset). Comment-only; rolls up under #145/#147. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two
data ingestfailures that cost customers a full upload before failing (from the 2026-07-07 deep dive of the ingest flow). Stacked on #142 — retargets todevelopwhen it merges.1. Destination-table guard — cli#70, P4-lite of backend#828
data listquery) after cluster discovery, before staging. Existing table without--overwrite→ exit 6 (new, documented) with the full remedy:--overwrite, a different--table, ordata delete. Previously: stage everything → submit → in-cluster DuplicateValidator fails → exit 9, upload burned.--overwritereplaces via the exact teardowndata deleteuses, acting on the matched name (not the flag's casing — Linux MySQL + PVC paths are case-sensitive; the flag spelling could silently no-op the DROP/rm and then claim success).--overwrite+--idempotency-keyrefused outright (adversarial-review catch): a replayed submit attaches to the previous run after the teardown deleted the data — false success + data loss.data deleteas the primary recovery; the teardown pod honors--stage-pod-image(air-gapped registries).2. Extension detection/emission — cli#68 (P5 seed)
.webpremoved from the accept-set: the ingestor'sFileExtensionenum + the ingest.v1 schema allow only .jpg/.jpeg/.png for images, andFileTypeValidatorraises on webp — accepting it locally guaranteed an in-cluster failure after the full upload.images: 3 files (.png)) and emitted asspec.file_options.extension, so the cluster validates the type that was actually staged. Previously it checked its.jpegconvention default and rejected .jpg/.png datasets after upload..jpg ×1, .png ×3, exit 3); all-unsupported datasets get told what was found vs accepted.Verification
--overwrite --dry-runcreates nothing · mixed-extension refusal · combo-flag refusal.go build/vet/ fullgo test ./...green; new tests pin the guard seam (matched-name contract, fail-open), extension detection, spec emission + schema validation, keypoint top-level fields, and the summary rendering.Refs: cli#68 · cli#70 · backend#828 (P4/P5) · backend#879.
🤖 Generated with Claude Code