Uh oh!
There was an error while loading. Please reload this page.
release-train: develop -> staging - #648
Merged
Merged
Conversation
* docs(claude): sync org-standards block (backend#1602) Managed sync from tracebloc/.github/org-standards.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(claude): sync org-standards block (backend#1602) Managed sync from tracebloc/.github/org-standards.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(claude): sync org-standards block (backend#1602) Managed sync from tracebloc/.github/org-standards.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Bugbot #644 (High), recurrence of #629. The checksum fetch picked field 1 of any line mentioning "Docker.dmg". A TLS-inspecting proxy that returns an HTML error body mentioning that filename yields non-hash text, which was non-empty, so the code entered the fail-closed verify path, failed the compare, and hard-aborted an otherwise-fine install as "corrupted or tampered". Add the 64-hex structure check the PowerShell tool downloads already have: - awk now requires field 1 to be a 64-hex SHA-256 before capturing it - a belt-and-suspenders guard blanks any non-64-hex value, so garbage takes the intended warn/unreachable path instead of a fail-closed mismatch abort Real corruption/tampering still fails closed: a valid 64-hex hash that doesn't match the DMG aborts exactly as before (#556). Regenerated scripts/manifest.sha256 (setup-macos.sh is manifest-covered, R8). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka
commented
Aug 10, 2026
ContributorAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 63f08a6. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated promotion by the release train (RFC-0008 D14). Head is the train-managed
release-train/to-stagingbranch (a mirror ofdevelop), so it never collides with a human PR. Merged only when the fr-gate is green.Note
Low Risk
Docs sync and defensive installer logic; real checksum mismatch still fails closed when a valid hash is fetched.
Overview
Release-train promotion mirroring
developintostaging; the meaningful deltas are documentation sync and a macOS installer hardening fix.CLAUDE.mdgains the org-wide tracebloc engineering standards block (betweenorg-standardsmarkers): branch/PR workflow, quality bar, kanban, release train rules, issue filing, and AI-session guardrails—canonical source istracebloc/.github/org-standards.md, not edited in-repo.scripts/lib/setup-macos.shtightens Docker Desktop DMG verification so a TLS/proxy HTML error page that merely mentionsDocker.dmgcannot be mistaken for a checksum. Parsing now requires a 64-hex SHA-256 inchecksums.txt, with an extra bash guard that clears invalid values and falls through to the existing unverified install + warn path instead of aborting with a false “tampered” mismatch.scripts/manifest.sha256is updated for the changedsetup-macos.sh.Reviewed by Cursor Bugbot for commit 63f08a6. Bugbot is set up for automated code reviews on this repo. Configure here.