Uh oh!
There was an error while loading. Please reload this page.
docs(http1): say what the awaited writev size check guards (#179) - #188
Closed
EdmondDantes wants to merge 1 commit into
Closed
docs(http1): say what the awaited writev size check guards (#179)#188EdmondDantes wants to merge 1 commit into
EdmondDantes wants to merge 1 commit into
Conversation
Contributor
CoverageTotal lines: 82.13% → 81.94% (-0.19 pp)
|
EdmondDantesforce-pushed
the
179-writev-short-write
branch
from
August 21, 2026 06:37
853131d to
5538626CompareEdmondDantes
commented
Aug 21, 2026
ContributorAuthor
Folded into #191 — the three-line comment and the measurement it describes belong in one pull request, not two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One comment.
http_connection_send_strv_awaitedcomparestransferredagainst its ownsum, which reads as a byte count check and is not one: all-or-nothing is libuv's write
contract, and on success the completion reports the sum the reactor was handed.
The review that produced this line also produced true-async/php-async#263, which fixes what
the comparison could not catch — a write silently narrowed to 32 bits and reported as
complete, and a request that outlived the handle it pointed at.