Uh oh!
There was an error while loading. Please reload this page.
docs(bench): what a streamed chunk actually costs on HTTP/1 (#179) - #191
Merged
Conversation
Contributor
CoverageTotal lines: 82.13% → 82.20% (+0.07 pp)
|
EdmondDantesforce-pushed
the
h1-queue-measurement
branch
from
August 21, 2026 06:19
0ddccd0 to
ab75522CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#179 rests on "three submits and up to three suspensions per chunk". Measured on
e246dcfwith the release PHP at ABI 0.25,strace -f -caroundtests/perf/servers/server_stream.php, two runs per chunk size differing only in thenumber of chunks so the difference divides out startup:
One submit and one park per chunk, flat in the chunk size — a 64 KiB frame takes the
copy-free path and still leaves as one
writev, because its three pieces are three slots.So the premise is gone. What a queue could still remove is the park, and only by making
the write fire-and-forget — which is exactly what
isWritable()andtryWrite()wouldthen have nothing honest to say about.