Uh oh!
There was an error while loading. Please reload this page.
feat(abg)!: provide untyped fields always and typed ones if type available - #1603
Merged
Conversation
This was referenced Aug 19, 2024
CollaboratorAuthor
Vampireforce-pushed
the
vampire/custom-types
branch
from
August 19, 2024 10:21
77c3c5f to
038cf30CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 19, 2024 10:21
6ff7eaa to
edb501aCompareVampireforce-pushed
the
vampire/custom-types
branch
from
August 19, 2024 10:50
038cf30 to
c318448CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 19, 2024 10:50
edb501a to
27ac4e9CompareVampireforce-pushed
the
vampire/custom-types
branch
from
August 19, 2024 10:59
c318448 to
2d36b76CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 19, 2024 10:59
27ac4e9 to
6245b49CompareVampireforce-pushed
the
vampire/custom-types
branch
from
August 19, 2024 11:48
2d36b76 to
2b90ea5CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
2 times, most recently
from
August 19, 2024 12:40
50b61d2 to
aec4604CompareVampire
changed the base branch from
vampire/custom-types
to
vampire/fix-compile-error-in-generated-bindingAugust 19, 2024 12:40
Vampireforce-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 19, 2024 13:15
3d2d1e4 to
15ec5e5CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
2 times, most recently
from
August 19, 2024 13:31
4396d5f to
c0f0047Compare
This was referenced Aug 19, 2024
Vampireforce-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 19, 2024 18:09
15ec5e5 to
4df2422CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 19, 2024 18:16
c0f0047 to
8598958Compare
This was referenced Aug 20, 2024
This was referenced Aug 20, 2024
Vampireforce-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 20, 2024 10:45
4df2422 to
5d905c7CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 20, 2024 10:45
8598958 to
1c2deeeCompareVampireforce-pushed
the
vampire/fix-compile-error-in-generated-binding
branch
from
August 20, 2024 11:25
5d905c7 to
4baa120CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 20, 2024 11:25
1c2deee to
750cae1CompareVampire
changed the base branch from
vampire/fix-compile-error-in-generated-binding
to
graphite-base/1603August 20, 2024 11:53
Vampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 20, 2024 11:53
750cae1 to
544b41dCompareVampireforce-pushed
the
graphite-base/1603
branch
from
August 20, 2024 11:53
4baa120 to
0e91c56CompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 20, 2024 11:53
544b41d to
dd67688Comparekrzema12
requested changes
Aug 21, 2024
krzema12
left a comment
Member
There was a problem hiding this comment.
Impressive, thanks! Just several minor things to discuss/fix.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Vampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 21, 2024 23:59
dd67688 to
abfd5e0CompareVampire
changed the base branch from
main
to
vampire/make-pair-building-pretty-againAugust 21, 2024 23:59
Vampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 22, 2024 00:26
abfd5e0 to
d513b9bCompareVampireforce-pushed
the
vampire/untyped-bindings
branch
from
August 22, 2024 00:35
d513b9b to
bc71f66CompareVampire
commented
Aug 22, 2024
CollaboratorAuthor
Additionally to the requested changes I also added a required tag to the KDoc for the cases where nullability does not reflect required status, i.e. in the typed class for typed properties. |
krzema12
changed the base branch from
vampire/make-pair-building-pretty-again
to
graphite-base/1603August 22, 2024 15:03
krzema12force-pushed
the
vampire/untyped-bindings
branch
from
August 22, 2024 15:03
bc71f66 to
daa99c0Comparekrzema12
approved these changes
Aug 22, 2024
Member
I approved, but it looks like CI didn't run. Any idea why? Retriggered by creating a copy of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes#1585
I have to confess, that I did not check every change in the unit test workflow files,
so they should probably be looked again closely. But I think it should have done the right thing.
Or at least how I envisioned it.
no typing =>
_Untypedclass with_Untypedpropertiesfull typing =>
_Untypedclass as above@Deprecatedwith a replace hint for the typed class (works in the IDE),partly typing =>
_Untypedand typed class as above_Untypedproperty is added