Skip to content

fix(abg): Use "a.to(b)" instead of "a to b" - #1607

Merged
Vampire merged 1 commit into
mainfrom
vampire/fix-compile-error-in-generated-binding
Aug 20, 2024
Merged

fix(abg): Use "a.to(b)" instead of "a to b"#1607
Vampire merged 1 commit into
mainfrom
vampire/fix-compile-error-in-generated-binding

Conversation

@Vampire

@VampireVampire commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

Or Kotlin Poet sometimes breaks before the "to" which is illegal.

@VampireGraphite App

Vampire commented Aug 19, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@Vampire
Vampireforce-pushed the vampire/fix-compile-error-in-generated-binding branch from 3d2d1e4 to 15ec5e5CompareAugust 19, 2024 13:15
@krzema12krzema12 changed the title fix(abg): Use "a.to(b)" instead of "a to b" or Kotlin Poet sometimes breaks before the "to" which is illegalfix(abg): Use "a.to(b)" instead of "a to b"Aug 19, 2024
@krzema12

Copy link
Copy Markdown
Member

Made the title a bit shorter by moving the rest to the description (I hope Graphite will merge it this way).

krzema12
krzema12 previously approved these changes Aug 19, 2024
@Vampire

Copy link
Copy Markdown
CollaboratorAuthor

I also changed the commit message accordingly to be on the safe side :-)

Or Kotlin Poet sometimes breaks before the "to" which is illegal.
@Vampire
Vampireforce-pushed the vampire/fix-compile-error-in-generated-binding branch from 5d905c7 to 4baa120CompareAugust 20, 2024 11:25
@Vampire
Vampire changed the base branch from vampire/custom-types to mainAugust 20, 2024 11:25
@Vampire
Vampire dismissed krzema12’s stale reviewAugust 20, 2024 11:25

The base branch was changed.

@VampireGraphite App

Vampire commented Aug 20, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Merge activity

  • Aug 20, 7:52 AM EDT: @Vampire started a stack merge that includes this pull request via Graphite.
  • Aug 20, 7:53 AM EDT: @Vampire merged this pull request with Graphite.

@Vampire
Vampire merged commit 0e91c56 into mainAug 20, 2024
@Vampire
Vampire deleted the vampire/fix-compile-error-in-generated-binding branch August 20, 2024 11:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Vampire@krzema12