Uh oh!
There was an error while loading. Please reload this page.
Development - #21
Conversation
back propagate changes from JOSS branch into the dev branch
Add JOSS doi etc (Note this will show errors until the paper is formally accepted)
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a critical bug in the KDTree algorithm and updates the README with JOSS publication information. The bug fix corrects the conditional logic for returning distance values, while the README updates add references to the Journal of Open Source Software publication.
- Fixes incorrect conditional logic in KDTree distance calculation
- Adds JOSS publication reference and DOI to README
- Updates README section heading for better organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/underworld3/ckdtree.pyx | Fixes bug in KDTree where squared distances and regular distances were returned incorrectly |
| README.md | Adds JOSS publication information and updates references section heading |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
* New Container file setup and moving Dockerfile to ContainerFile * Remove old dockerfile * add launch script * Simplification of Containerfile with new example usage * yml -> yaml: for consistency * New Containerfile and container launch script. This assumes containers will be run with `podman` and only in 'rootless podman' mode. This more is much better than 'rootful podman' or docker. * rename .yml -> .yaml * remove obsolete comment * Update build_uw3_and_test.yaml * call environment something different to 'base' * Turn off verbosity in Container image build. * Reactivate cache environment.yaml for GH workflow. * Pyvista now working in container * Fixing sym links * Adding a README.md Some useful links and overall desciption of the container technology used. * Adding a README.md Some useful links and overall desciption of the container technology used. * Update link
… work. Also added pytest for Poisson (scalar) natural BC (#26)
lmoresi
commented
Jan 18, 2026
dev to main for the purposes of bringing the new code in to development for wider testing. |
Uh oh!
There was an error while loading. Please reload this page.
This brings the README updates (these include the JOSS publication information).
The nasty bug that I introduced into the kdtree algorithm - a fix for this, I mean !
That's all.