feat(isStrongPassword): add 'extendSymbols' option by fedeci · Pull Request #1564 · validatorjs/validator.js

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

fedeci · 2020-12-29T13:33:00Z

The extendSymbols option allows to extend the default set of symbols available for isStrongPassword.

Fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2020-12-29T13:36:00Z

Codecov Report

Merging #1564 (fcbd9b5) into master (63b6162) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1564 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1843 1844 +1 =========================================
+ Hits 1843 1844 +1

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6162...fcbd9b5. Read the comment docs.

stingalleman · 2021-01-01T03:41:51Z

I think @ should be included by default, so I submitted #1566. I still believe this is a good PR, however.

profnandaa

LGTM, thanks for the PR.

./cc @tux-tn @ezkemboi

tux-tn

LGTM ! Thank you @fedeci for your great contributions! Can you please fix merge conflicts?

fedeci · 2021-03-19T17:08:58Z

Here it is😄

tux-tn · 2021-03-19T19:05:57Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const defaultSymbols = '-#!$@%^&*()_+|~=`{}\\[\\]:";\'<>?,.\\/ ';


A little question about this regex, i know that you just used the existing symbolRegex but is there any special reason for not matching the Back slash character \ ?

Really Idk.
@profnandaa what do you think?

@profnandaa @ezkemboi any feedbacks on this?

profnandaa

I'll fix the m/c, never mind.

profnandaa · 2023-01-31T06:06:38Z

closed in #1566

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

profnandaa previously approved these changes Feb 15, 2021
View reviewed changes

profnandaa added the needs-more-review label Feb 15, 2021

tux-tn requested changes Mar 18, 2021
View reviewed changes

fedeci added 2 commits March 19, 2021 18:00

feat(isStrongPassword): add 'extendSymbols' option
d19cd42

docs: update docs
629535e

fedeci dismissed profnandaa’s stale review via 629535eMarch 19, 2021 17:04

fedeci force-pushed the improve-is-strong-password branch from 048ed67 to 629535eCompare March 19, 2021 17:04

Update tests
fcbd9b5

fedeci requested review from profnandaa and tux-tn March 19, 2021 17:09

tux-tn reviewed Mar 19, 2021
View reviewed changes

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM labels Dec 12, 2022

profnandaa approved these changes Dec 12, 2022
View reviewed changes

profnandaa closed this Jan 31, 2023

fedeci deleted the improve-is-strong-password branch February 4, 2023 14:37

jeromemacias mentioned this pull request Aug 7, 2026
Validator does not recognise € as symbol #2844
Closed

Uh oh!

Uh oh!

Conversation

fedeci commented Dec 29, 2020

Checklist

Uh oh!

codecovBot commented Dec 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stingalleman commented Jan 1, 2021

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

tux-tn left a comment

Choose a reason for hiding this comment

Uh oh!

fedeci commented Mar 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

profnandaa commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

fedeci commented Dec 29, 2020

Checklist

Uh oh!

codecovBot commented Dec 29, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stingalleman commented Jan 1, 2021

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

tux-tn left a comment

Choose a reason for hiding this comment

Uh oh!

fedeci commented Mar 19, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

profnandaa left a comment

Choose a reason for hiding this comment

Uh oh!

profnandaa commented Jan 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

codecovBot commented Dec 29, 2020•
edited
Loading

codecovBot commented Dec 29, 2020•
edited
Loading

codecovBot commented Dec 29, 2020•
edited
Loading