feat(isStrongPassword): add `@` as valid symbol by stingalleman · Pull Request #1566 · validatorjs/validator.js

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman · 2021-01-01T03:35:34Z

adds @ as a valid symbol, also fixes#1563

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

codecov · 2021-01-01T03:38:33Z

Codecov Report

Merging #1566 (adab6e4) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #1566 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 100 100 Lines 1796 1796 =========================================
Hits 1796 1796

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...adab6e4. Read the comment docs.

thedevelinmycode · 2021-02-06T19:58:39Z

Looking forward to seeing this merged in. Spent an hour debugging my password validation to realize the @ symbol wasn't part of the regex lmao

stingalleman · 2021-02-07T14:33:40Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

thedevelinmycode · 2021-02-07T21:09:16Z

Same, is there any update on this? It's a dead-simple PR, ready to be merged.

Probably gonna have to ping an owner or something.

renanmontebelo · 2021-02-08T04:41:34Z

 const lowerCaseRegex = /^[a-z]$/;
 const numberRegex = /^[0-9]$/;
-const symbolRegex = /^[-#!$%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;
+const symbolRegex = /^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/;


Should we do /^[\W_ ]$/ instead?

I think it's better to hardcode specific characters.

If that's the case then we should include in the documentation that this function is restricted to ASCII characters only and symbols such as º or § will not work, which will be quite a surprise for some locales that have these symbols in their keyboards.
It would work with /^[\W_ ]$/ though.

Hmm, that's true. I don't know if people use these "weird" characters in their password? Personally I've never seen someone do that but I dunno. Maybe it is better to do that other regex

stingalleman · 2021-02-10T12:19:07Z

@profnandaa @ezkemboi @tux-tn any update?

tux-tn

LGTM 🎉
Thank you for your contribution @stingalleman

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

stingalleman force-pushed the master branch from 0a08d39 to adab6e4Compare January 1, 2021 03:40

stingalleman changed the title ~~feat(isGoodPassword): add @ as valid symbol~~feat(isStrongPassword): add @ as valid symbolJan 1, 2021

feat(isStrongPassword): add @ as valid symbol
adab6e4

stingalleman mentioned this pull request Jan 1, 2021
feat(isStrongPassword): add 'extendSymbols' option #1564
Closed
3 tasks

keesvv approved these changes Feb 7, 2021
View reviewed changes

renanmontebelo reviewed Feb 8, 2021
View reviewed changes

tux-tn approved these changes Feb 13, 2021
View reviewed changes

tux-tn added ✅ LGTM 🎉 first-pr labels Feb 13, 2021

profnandaa merged commit 9b03daf into validatorjs:masterFeb 15, 2021

sang-uk-lee mentioned this pull request Mar 9, 2021
isStrongPassword() does not count '@' sign as a symbol express-validator/express-validator#1006
Closed

profnandaa mentioned this pull request Apr 19, 2021
[release staging] April 2021 Release (v13.6.0) #1650
Closed

WikiRik mentioned this pull request Jan 11, 2023
Add GBP (£) to Symbol List #2146
Closed

Uh oh!

Uh oh!

Conversation

stingalleman commented Jan 1, 2021

Checklist

Uh oh!

codecovBot commented Jan 1, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thedevelinmycode commented Feb 6, 2021

Uh oh!

stingalleman commented Feb 7, 2021

Uh oh!

thedevelinmycode commented Feb 7, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stingalleman commented Feb 10, 2021

Uh oh!

tux-tn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

stingalleman commented Jan 1, 2021

Checklist

Uh oh!

codecovBot commented Jan 1, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thedevelinmycode commented Feb 6, 2021

Uh oh!

stingalleman commented Feb 7, 2021

Uh oh!

thedevelinmycode commented Feb 7, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stingalleman commented Feb 10, 2021

Uh oh!

tux-tn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

stingalleman commented Jan 1, 2021

Checklist

Uh oh!

codecovBot commented Jan 1, 2021•
edited
Loading

codecovBot commented Jan 1, 2021•
edited
Loading

codecovBot commented Jan 1, 2021•
edited
Loading

codecovBot commented Jan 1, 2021•
edited
Loading