Add GBP (£) to Symbol List

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148

[richard-bridgeman]

Added the GBP £ pound sign in to Symbol List

[pano9000]

Hi,

thanks for the PR. :-)
A) The change you made is not a valid RegExp though, you would need to add the symbol inside the "range" expression here:

so from:
/^[-#!$@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$£/;
you would need to change to
/^[-#!$£@%^&*()_+|~=`{}\[\]:";'<>?,.\/ ]$/

However, regardless of that error:
the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

Thanks!

[pano9000]

this PR belongs to issue #2145

[WikiRik]

However, regardless of that error: the question would still be, if adding the GBP symbol here makes sense or not - I will have a look at this later this evening and provide some feedback :-)

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

Apart from fixing the RegExp it would also be nice if a new test case could be added using £

[pano9000]

The previous addition to the symbol list did not include any clarification on which symbols are supposed to be in that list so I think this addition is fine.

after checking isStrongPassword's history and PRs, I agree - the change from this PR seems fine, with the current state of isStrongPassword.

(I will likely create a new issue about it though, as I don't really think the current state is really that ideal -> but that is a separate topic :-))

[profnandaa]

Sorry, closing as duplicate of #2148