maintenance: 2405 release - #2269

Closed
profnandaa wants to merge 27 commits into
release/2308bfrom
master
Closed

maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom
master

Conversation

@profnandaa

@profnandaaprofnandaa commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".

This is being repurposed to the May 2024 release.

13.12.0

New Features / Validators

Fixes, New Locales and Enhancements

tomaspanekand others added 4 commits August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik approved these changes Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa

profnandaa commented Aug 19, 2023

Copy link
Copy Markdown
MemberAuthor

Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.

@rubiin

rubiin commented Aug 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@profnandaa

profnandaa commented Aug 21, 2023

Copy link
Copy Markdown
MemberAuthor

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

@rubiin

rubiin commented Aug 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped

@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?

I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator
We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.
The first version can be a simple copy paste.

@WikiRikWikiRik mentioned this pull request Sep 4, 2023
Closed
@WikiRik

WikiRik commented Sep 20, 2023

Copy link
Copy Markdown
Member

@profnandaa any chance we can get this release out soon?

@profnandaa

profnandaa commented Sep 20, 2023

Copy link
Copy Markdown
MemberAuthor

@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.

@WikiRik

WikiRik commented Sep 20, 2023

Copy link
Copy Markdown
Member

What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)

@tomaspanektomaspanek mentioned this pull request Dec 2, 2023
Merged
4 tasks
ZhulinskiiDaniland others added 2 commits March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin

rubiin commented Mar 28, 2024

Copy link
Copy Markdown
Member

I have add LGTM labels to few issues, we can add them to this pipeline

@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa

profnandaa commented Apr 25, 2024

Copy link
Copy Markdown
MemberAuthor

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.
I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

@profnandaa

profnandaa commented Apr 25, 2024

Copy link
Copy Markdown
MemberAuthor

Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22

@profnandaaprofnandaa changed the title maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa

profnandaa commented Apr 25, 2024

Copy link
Copy Markdown
MemberAuthor

UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land

rubiinand others added 2 commits April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin

rubiin commented Apr 27, 2024

Copy link
Copy Markdown
Member

Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status

urgand others added 3 commits April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin

rubiin commented Apr 27, 2024

Copy link
Copy Markdown
Member

@WikiRik --

this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.

Then we work on a follow up release in a month's time.

Thanks for your help in reviewing the PRs and keeping the lights on!

#2391 this should fix the problem both on CI and local installs.

@profnandaaprofnandaa changed the title maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa

profnandaa commented May 2, 2024

Copy link
Copy Markdown
MemberAuthor

@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.

WikiRik
WikiRik approved these changes May 2, 2024
View reviewed changes

@WikiRikWikiRik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!

@WikiRikWikiRik mentioned this pull request May 7, 2024
Closed
@profnandaa

profnandaa commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0
And once again, thanks @WikiRik and @rubiin for your reviews!

@profnandaaprofnandaa mentioned this pull request Dec 23, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000
+1 more reviewer
@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dont-mergemaintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
maintenance: 2405 release - #2269
Closed
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Closed
maintenance: 2405 release#2269
profnandaa wants to merge 27 commits into
release/2308bfrom 
master
Conversation
@profnandaa
@profnandaaprofnandaa
commented
Aug 18, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This is a B release, post the main last major one #2252 , mainly to fix the regression in isDate but escorted with a few more "feature patches".
This is being repurposed to the May 2024 release.
13.12.0
New Features / Validators
Fixes, New Locales and Enhancements
tomaspanekand others
added 4 commits
August 18, 2023 15:42
@tomaspanek
fix(isDate): Timezone Offset Fix (#2257)
2c4aede
* Timezone Offset Fix & Parsing with Leading Zeros
* `isDate` Timezone Mock Test, Support for NodeJS <8
* `isDate` Unit Test Resiliency Improvement
@estefrare
feat(isTaxId): add tax id for Argentina, es-AR (#2224)
3541b0d
@GMorris-professional
feat(isPassportNumber): added South African, ZA validator (#2265)
6923860
* Included Regex for South African Passport Number
* Corrected Passport validation
* Update README.md
@simrrunnn
feat(isMobilePhone): Added the regex for Malawi en-MW (#2267)
b958bd7
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
* Added the regex and tests for Malawi phone number validation
WikiRik
WikiRik
approved these changes
Aug 18, 2023
View reviewed changes
Comment threadsrc/lib/isPassportNumber.js
@profnandaa
profnandaa
commented
Aug 19, 2023

Copy link


Copy Markdown

MemberAuthor
Sorry I'll delay the release to Monday. I'm also struggling having clean builds but has nothing to do with the new changes.
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@profnandaa
profnandaa
commented
Aug 21, 2023

Copy link


Copy Markdown

MemberAuthor
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
@rubiin
rubiin
commented
Aug 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@profnandaa How about we include the types in the package itself. That way it will be more easier to maintain it along with the actual lib itself. Also from the consumer point of view, this will result in one less dep, not to mention it will result in a more robust typesafety for them as we will also be changing the types file here itself instead of waiting for DefinitelyTyped
@rubiin -- I don't mind that. Could you do a few samples to see how that will look like?
I think most of it can be borrowed and added upon from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/validator

We might have to add a info on post install to let users know to prefer our types over types in DefinitelyTyped.

The first version can be a simple copy paste.
@WikiRikWikiRik
mentioned this pull request
Sep 4, 2023

Closed

@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
@profnandaa any chance we can get this release out soon?
@profnandaa
profnandaa
commented
Sep 20, 2023

Copy link


Copy Markdown

MemberAuthor
@WikiRik - struggled with getting a clean build last time and stalled. I need some help on that. Was building on latest Node.js stable.
@WikiRik
WikiRik
commented
Sep 20, 2023

Copy link


Copy Markdown

Member
What is the issue you got? I'm using Node 18.18.0 in a new GitHub Codespace with the default image and that works fine. You do need to use npm install --legacy-peer-deps, but that's a known issue (see #2123)
@tomaspanektomaspanek
mentioned this pull request
Dec 2, 2023
 Merged

4 tasks
ZhulinskiiDaniland others
added 2 commits
March 5, 2024 16:43
@ZhulinskiiDanil
fix(docs): misspelling of Mailto (#2368)
332b501
@WikiRik
chore(isMailtoURI): remove unnecessary default to (#2341)
4197b86
* chore: add additional testcases to isMailtoURI
Line 44 is only partially covered before this change
* chore: add additonal const to figure out which part is partial
* chore: add testcase for single ?
* chore: add another line to find partial coverage
* chore: remove default to
* chore: combine consts again
@rubiin
rubiin
commented
Mar 28, 2024

Copy link


Copy Markdown

Member
I have add LGTM labels to few issues, we can add them to this pipeline
@devmanbudMusa
fix(docs): fixed typo in README.md (#2371)
31c88cf
Co-authored-by: Musa <goat_musa@Musas-MBP.cust.communityfibre.co.uk>
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy.

I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
Currently reviewing all the LGTMs - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3A%22%E2%9C%85+LGTM%22
@profnandaaprofnandaa
changed the title
maintenance: post 2308 releasemaintenance: 2404 releaseApr 25, 2024
@amaliacatalina
fix(isPassportNumber): fix regex Azerbaijan (#2284)
752bd09
* Update isPassportNumber.js
Added the updated Azerbaijan passport validation:
See issue:
#2274
* Update validators.test.js
@profnandaa
profnandaa
commented
Apr 25, 2024

Copy link


Copy Markdown

MemberAuthor
UPDATE: now pending this mc-to-land s, which I'll do a fix PR for all of them, and then prep the release notes - https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land
rubiinand others
added 2 commits
April 25, 2024 13:16
@rubiin@WikiRik
ci: add latest node versions (#2364)
817e56e
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@GMorris-professional
fix(isPassport): added tests for ZA Passport Number (#2270)
72c8dc1
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
Lets try to include more stale prs(mc-to-land) as the number of prs are alot and the number might create a false impression for new contributors as well as users on the libs active status
urgand others
added 3 commits
April 27, 2024 17:03
@urg
fix: add SLE to the isISO4217 validator (#2273)
5677f91
@meyfa
chore: Publish to NPM with provenance (#2276)
2253a77
* chore: Publish to NPM with provenance
The release process in this repository is already automated via
GitHub Actions, which is a great first step toward creating trust in the
supply chain. Recently, NPM has started to support publishing with the
`--provenance` flag. This flag creates a link between the GitHub Actions
run that created the release and the final artifact on NPM. This linkage
further ensures that package installs can be traced back to a specific
code revision.
For more information on publishing with provenance, please refer to:
https://github.blog/2023-04-19-introducing-npm-package-provenance/
* chore: Use Node.js 18 for publishing to support provenance
@nandavikas
fix: symbolRegex in isStrongPassword to include '\' (#2278)
8a40349
* Modified symbolRegex in isStrongPassword to include '\'
* Modify test to check validity of strong password with \ character
@rubiin
rubiin
commented
Apr 27, 2024

Copy link


Copy Markdown

Member
@WikiRik --
this is the build errors I have been getting, I had to run with npm install --legacy-peer-deps to proceed.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: rollup-plugin-babel@4.4.0
npm ERR! Found: rollup@0.47.6
npm ERR! node_modules/rollup
npm ERR! dev rollup@"^0.47.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR! peer rollup@">=0.60.0 <3" from rollup-plugin-babel@4.4.0
npm ERR! node_modules/rollup-plugin-babel
npm ERR! dev rollup-plugin-babel@"^4.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Trying to upgrade these dev dependencies, sends everything else going crazy. I'll need help on modernizing our dev dependencies, but I think this shouldn't block our next release. So, I'm going to work on getting the next release on Monday. Will open a new PR detailing the release.
Then we work on a follow up release in a month's time.
Thanks for your help in reviewing the PRs and keeping the lights on!
#2391 this should fix the problem both on CI and local installs.
@profnandaaprofnandaa
changed the title
maintenance: 2404 releasemaintenance: 2405 releaseMay 2, 2024
@profnandaa
profnandaa
commented
May 2, 2024

Copy link


Copy Markdown

MemberAuthor
@rubiin@WikiRik@ezkemboi -- kindly take a look at the release notes (PR description) one last time and I should make the release today evening GMT.
WikiRik
WikiRik
approved these changes
May 2, 2024
View reviewed changes
@WikiRikWikiRik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update and the merger of recent PRs!
@WikiRikWikiRik
mentioned this pull request
May 7, 2024

Closed

@profnandaa
profnandaa
commented
May 9, 2024

Copy link


Copy Markdown

MemberAuthor
13.12.0 now released. Thanks all for the contribution! 🎉 https://www.npmjs.com/package/validator/v/13.12.0

And once again, thanks @WikiRik and @rubiin for your reviews!
@profnandaaprofnandaa
mentioned this pull request
Dec 23, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rubiinrubiinrubiin approved these changes
@WikiRikWikiRikWikiRik approved these changes
@ezkemboiezkemboiezkemboi approved these changes
@pano9000pano9000Awaiting requested review from pano9000

+1 more reviewer

@GMorris-professionalGMorris-professionalGMorris-professional left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

dont-mergemaintenance

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

20 participants

@profnandaa@rubiin@WikiRik@ezkemboi@GMorris-professional@tomaspanek@estefrare@simrrunnn@ZhulinskiiDanil@devmanbud@ruscon@amaliacatalina@RobinvanderVliet@anasshakil@songyuew@AlexKrupko@urg@meyfa@nandavikas@MatthieuLemoine