Add validation Hyphen before year is not allowed

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots:

[Sumit-tech-joshi]

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4197b86) to head (eadfad4).

Additional details and impacted files

@@ Coverage Diff @@## master #2381 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 107 107 Lines 2449 2451 +2 Branches 619 620 +1 =========================================
+ Hits 2449 2451 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[WikiRik]

Please add additional tests

[Sumit-tech-joshi]

Hi @WikiRik Can you explain what test case should i add as adding test case for this scenario as below will fail the test case.

'-2020-03-15'

[michiwo1]

I think it is good except for the tests.

[Sumit-tech-joshi]

Added test cases as requested

[WikiRik]

Can you add something like new Date('-2014-03-15') as well? Or does that give an error with the Date library already?

[Sumit-tech-joshi]

@WikiRik , When I added the new Date('-2014-03-15') to the test cases, it seems to be failing. Upon investigation, I found that the new Date('-2014-03-15') function returns a valid "full date string" (Sat Mar 15 2014 00:00:00 GMT-0700 (Pacific Daylight Saving Time)). Thank you for your attention to this matter.

Please see the screenshots: