Uh oh!
There was an error while loading. Please reload this page.
ci: fix git identity for changesets Version Packages commit - #1357
Conversation
|
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (16 failed)astro (1 failed):
example (2 failed):
express (5 failed):
hono (1 failed):
nextjs-turbopack (1 failed):
nextjs-webpack (2 failed):
sveltekit (3 failed):
vite (1 failed):
🌍 Community Worlds (55 failed)mongodb (2 failed):
redis (2 failed):
turso (51 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Set setupGitUser: false on changesets/action to prevent it from overwriting our git config with the hardcoded github-actions[bot] identity. The git identity is now configured in a prior step using the app-slug output from actions/create-github-app-token.
3a3153d to
fbda5eeCompareThere was a problem hiding this comment.
Pull request overview
Adjusts the release workflow so Changesets doesn’t override the Git author/committer identity, ensuring “Version Packages” commits are attributed to the GitHub App bot.
Changes:
- Adds an explicit
git config user.name/user.emailstep based onactions/create-github-app-token’sapp-slugoutput. - Sets
setupGitUser: falseonchangesets/action@v1to prevent it from resetting git identity togithub-actions[bot].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
…ignal * origin/main: fix: separate infrastructure vs user code error handling (#1339) Revert "Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes" Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes ci: fix git identity for changesets Version Packages commit (#1357) ci: configure git identity for GitHub App bot account (#1356) fix(cli): remove short flag collision on `-e` in health command (#1343) Fix flaky Vercel prod e2e tests by skipping CLI update check (#1350) Fix Windows `ERR_UNSUPPORTED_ESM_URL_SCHEME` in dynamic imports (#1346) Fix flaky hook test by replacing setTimeout with deterministic awaits (#1347) ci: use dedicated GitHub App token instead of shared PAT (#1351) [world-local] Enforce hook token uniqueness and atomicity, matches other worlds (#1348) fix(core): suppress stale WORKFLOW_VERCEL_* env var warning outside serverless runtime (#1345) # Conflicts: # packages/core/src/runtime/step-handler.ts
…ting * origin/main: Version Packages (beta) (#1352) [web] Fix stale `encryptionKey` closure in events list data hook (#1366) [web-shared][web] Improve o11y UX with decoupled pagination, stream virtualization, and decrypt actions (#1358) fix: separate infrastructure vs user code error handling (#1339) Revert "Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes" Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes ci: fix git identity for changesets Version Packages commit (#1357)
Summary
setupGitUser: falseonchangesets/actionto prevent it from overwriting our git config with the hardcodedgithub-actions[bot]identityapp-slugoutput fromactions/create-github-app-token, butchangesets/actionwas silently overwriting it via itssetupGitUserdefault (true)This ensures the "Version Packages" commit on the release PR is attributed to the GitHub App bot account.
Follow-up to #1351 and #1356.