Uh oh!
There was an error while loading. Please reload this page.
Fix race condition allowing duplicate hook_disposed events - #1523
Merged
Conversation
Concurrent workflow invocations could both post hook_disposed for the same hook, corrupting the event log with duplicate events. This mirrors the wait_completed race condition fixed in #1057/#1434. - world-local: Add writeExclusive lock file for hook_disposed (same pattern as wait_completed and step terminal states) - world-postgres: Use DELETE ... RETURNING to atomically detect if another caller already deleted the hook entity - suspension-handler: Improve log messages to distinguish hook-already- disposed (EntityConflictError) from run-already-completed (RunExpiredError) Fixes#1266 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 960f3b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (2 failed)nextjs-turbopack (2 failed):
🌍 Community Worlds (59 failed)mongodb (3 failed):
redis (2 failed):
turso (54 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a race where concurrent workflow invocations could both emit hook_disposed for the same hook, leading to duplicate events and replay corruption. The changes make hook disposal atomic in each World implementation and refine runtime logging for the expected “already disposed” case.
Changes:
- world-postgres: make hook disposal atomic via
DELETE ... RETURNING, throwingEntityConflictErroron concurrent duplicate disposal. - world-local: add a
writeExclusivelock file guard to prevent concurrent duplicatehook_disposed. - core: split logging paths for
EntityConflictErrorvsRunExpiredErrorduring hook disposal; add changeset.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/world-postgres/src/storage.ts | Atomically deletes hooks on hook_disposed and detects concurrent duplicates. |
| packages/world-local/src/storage/events-storage.ts | Adds exclusive lock file for hook disposal to prevent TOCTOU duplicates. |
| packages/world-local/src/storage.test.ts | Adds a concurrency regression test for duplicate hook_disposed. |
| packages/core/src/runtime/suspension-handler.ts | Improves logging differentiation for duplicate disposal vs expired runs. |
| .changeset/fix-duplicate-hook-disposed-race.md | Declares patch releases for affected packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1972
to
+1974
| expect((rejected[0] as PromiseRejectedResult).reason).toMatchObject({ | ||
| name: 'EntityConflictError', | ||
| }); |
There was a problem hiding this comment.
This concurrency test can be flaky: disposeHook() may reject with HookNotFoundError (not EntityConflictError) if one disposal deletes the hook file before the other call reaches the hook existence validation in events-storage. Consider broadening the assertion to accept either error, or introduce a barrier so both calls reach the disposal section before one completes.
Suggested change
| expect((rejected[0]asPromiseRejectedResult).reason).toMatchObject({ | |
| name: 'EntityConflictError', | |
| }); | |
| constreason=(rejected[0]asPromiseRejectedResult).reasonas{ | |
| name?: string; | |
| }; | |
| expect(['EntityConflictError','HookNotFoundError']).toContain(reason.name); |
ContributorAuthor
There was a problem hiding this comment.
Already addressed in e604643 — the test now accepts both EntityConflictError and HookNotFoundError.
The concurrent hook_disposed race has two possible orderings: the loser may hit the lock file (EntityConflictError) or find the hook entity already deleted by the winner (HookNotFoundError). Both are correct. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pranaygp
commented
Mar 26, 2026
ContributorAuthor
failings tests are confirmed flaky from unrelated race conditions and queue timeout issues. merging this and investigating those |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hook_disposedfor the same hook, corrupting the event log with duplicate events and causingUnconsumed event in event log: eventType=hook_disposederrors on replaywriteExclusivelock file guard before hook deletion (same pattern aswait_completedfrom [world-postgres, world-local] Fix TOCTOU races in entity state transitions #1434)DELETE ... RETURNINGso only one concurrent caller succeeds — second getsEntityConflictErrorEntityConflictErrorbymakeRequestEntityConflictError(hook already disposed) fromRunExpiredError(run completed) log messagesFixes#1266
Test plan
should reject concurrent hook_disposed for the same hooktest (mirrors existingwait_completedrace test)🤖 Generated with Claude Code